HLRC: Get Deprecation Info API #36279
Conversation
This commit adds the Get Deprecation Info API and associated documentation. Relates elastic#29827
|
Pinging @elastic/es-core-features |
| static Request getDeprecationInfo(DeprecationInfoRequest deprecationInfoRequest) { | ||
| String endpoint = new RequestConverters.EndpointBuilder() | ||
| .addCommaSeparatedPathParts(deprecationInfoRequest.getIndices()) | ||
| .addPathPartAsIs("_xpack", "migration", "deprecations") |
There was a problem hiding this comment.
In 7.0 this should use _migration/deprecations as of #35976, although in 6.x it will have to use _xpack.
There was a problem hiding this comment.
Do u think its worth me doing that in a new PR after this so i can backport it back, similar to the way we did the other PRs?
There was a problem hiding this comment.
lol i guess i dont have a choice!
> Warnings: [[GET /{index}/_xpack/migration/deprecations] is deprecated! Use [GET /{index}/_migration/deprecations] instead.]
|
|
||
| public enum Level { | ||
| NONE, | ||
| INFO, |
There was a problem hiding this comment.
Soon (likely tomorrow) I'll have a PR removing NONE and INFO from this list server-side - whichever merges last will have to remove them from this list too.
There was a problem hiding this comment.
++ pls link the PR when u have it
client/rest-high-level/src/test/java/org/elasticsearch/client/MigrationIT.java
Show resolved
Hide resolved
| [id="{upid}-{api}-response"] | ||
| ==== Get Deprecation Info Response | ||
|
|
||
| The returned +{response}+ contains the cluster, index and node level deprecations. |
There was a problem hiding this comment.
This is awkward and not very clear, do you think we could reword it to something like:
| The returned +{response}+ contains the cluster, index and node level deprecations. | |
| The returned +{response}+ contains information about deprecated features currently in use at the cluster, node, and index level. |
There was a problem hiding this comment.
woah what is this black magic commit suggestion thing? I kinda want to click it just to have played around with it!
This commit adds the Get Deprecation Info API and associated documentation. Note: This commit is different from master as it adds back the _xpack portion of the API. Relates #29827
This commit adds the Get Deprecation Info API and associated
documentation.
Relates #29827