Reduce composite references at network level #36400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating `CompositeBytesReference` has more overhead than a single `ByteBufferReference`. Many of our messages will be contained to a single `ByteBuffer`. This commit avoids creating composite instances when there is 0 or 1 underlying `ByteBuffers`.
Tim-Brooks
added
>non-issue
:Distributed Coordination/Network
|
Pinging @elastic/es-distributed |
|
No need to backport this as nio is not on 6.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating
CompositeBytesReferencehas more overhead than a singleByteBufferReference. Many of our messages will be contained to asingle
ByteBuffer. This commit avoids creating composite instanceswhen there is 0 or 1 underlying
ByteBuffers.