[Monitoring] LocalExporter should catch synchronous exceptions #36606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the unlikely scenario that `LocalExporter::resolveBulk` throws an exception, then we should mark the `listener` as having failed.
|
Pinging @elastic/es-core-features |
martijnvg
approved these changes
Dec 13, 2018
...onitoring/src/main/java/org/elasticsearch/xpack/monitoring/exporter/local/LocalExporter.java
Outdated
Show resolved
Hide resolved
pickypg
added a commit
that referenced
this pull request
Dec 13, 2018
In the unlikely scenario that `LocalExporter::resolveBulk` throws an exception, then we should mark the `listener` as having failed.
|
6.x/6.6: 64f8f86 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the unlikely scenario that
LocalExporter::resolveBulkthrows an exception, then we should mark thelisteneras having failed.As discussed with @martijnvg, this is a follow-up to #35765, which already ensured that this call was async, but did not catch the [unlikely] exception.
A future PR should cleanup the
LocalExporterto make it a bit cleaner to test (more unit tests and less integration tests taking 20s+) as well remove the dependence on receiving cluster state changes to initialize the exporter.Closes #35797