SQL: Enhance message for PERCENTILE[_RANK] with field as 2nd arg #36933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhance erro message for the case that the 2nd argument of PERCENTILE and PERCENTILE_RANK is not a foldable, as it doesn't make sense to have a dynamic value coming from a field. Fixes: elastic#36903
|
Pinging @elastic/es-search |
matriv
changed the title
costin
requested changes
Dec 28, 2018
| @@ -61,6 +62,10 @@ public DataType dataType() { | |||
|
|
|||
| @Override | |||
| public String innerName() { | |||
| if (!percent.foldable()) { | |||
There was a problem hiding this comment.
The check happens too late when the Percentile is going to be executed. It's better to move it up-front in the resolveType since that's where we typically check the arguments.
This would also avoid having to create an exception and instead return a resolution message.
|
@costin Thanks for the comment, Fixup pushed. |
|
run the gradle build tests 2 |
astefan
approved these changes
Jan 3, 2019
|
@astefan Thanks for the comment, added a more detailed explanation there. |
costin
approved these changes
Jan 3, 2019
| @@ -41,13 +42,17 @@ public Percentile replaceChildren(List<Expression> newChildren) { | |||
|
|
|||
| @Override | |||
| protected TypeResolution resolveType() { | |||
| TypeResolution resolution = super.resolveType(); | |||
| if (!percent.foldable()) { | |||
| throw new SqlIllegalArgumentException("2nd argument: [{}] of PERCENTILE cannot be based on " + | |||
There was a problem hiding this comment.
I would rephrase this to something shorter such as "must be a constant, received [{}]".
matriv
added a commit
that referenced
this pull request
Jan 3, 2019
) Enhance error message for the case that the 2nd argument of PERCENTILE and PERCENTILE_RANK is not a foldable, as it doesn't make sense to have a dynamic value coming from a field. Fixes: #36903
|
Backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance error message for the case that the 2nd argument of PERCENTILE
and PERCENTILE_RANK is not a foldable, as it doesn't make sense to have
a dynamic value coming from a field.
Fixes: #36903