Stop automatically nesting mappings in index creation requests (backport to 6.x). #37132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtibshirani
added
>bug
:Search Foundations/Mapping
|
Pinging @elastic/es-search |
jtibshirani
force-pushed
the
create-index-mappings
branch
from
fbfd8ad to
59ac655
Compare
…tic#36924) Now that we unwrap mappings in DocumentMapperParser#extractMappings, it is not necessary for the mapping definition to always be nested under the type. This leniency around the mapping format was added in 2341825.
jtibshirani
force-pushed
the
create-index-mappings
branch
from
59ac655 to
8baf144
Compare
jtibshirani
force-pushed
the
create-index-mappings
branch
from
fdca865 to
8bd2d8d
Compare
|
Closing this PR for now, since we ran into issues with the original change on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #36924. There was an additional serialization change required that was not present in the original PR.