[Zen2] Remove initial master node count setting #37150
Conversation
DaveCTurner
added
>non-issue
v7.0.0
:Distributed Coordination/Cluster Coordination
|
Pinging @elastic/es-distributed |
DaveCTurner
changed the title
...org/elasticsearch/action/admin/cluster/bootstrap/TransportGetDiscoveredNodesActionTests.java
Outdated
Show resolved
Hide resolved
...org/elasticsearch/action/admin/cluster/bootstrap/TransportGetDiscoveredNodesActionTests.java
Outdated
Show resolved
Hide resolved
| internalCluster().setDisruptionScheme(disruptionScheme); | ||
| disruptionScheme.startDisrupting(); | ||
|
|
||
| final Client remainingClient = client(); |
There was a problem hiding this comment.
I'm confused. Why capture the client here and not just use client() at usage sites below?
There was a problem hiding this comment.
We first check that we have a client to a node that has applied the no-master block. The alternative would be to wait for all nodes to apply the no-master block before proceeding.
There was a problem hiding this comment.
However the name was a hangover from the earlier implementation that shut nodes down, so I renamed it in 788df4a.
test/framework/src/test/java/org/elasticsearch/test/test/InternalTestClusterTests.java
Outdated
Show resolved
Hide resolved
test/framework/src/test/java/org/elasticsearch/test/test/InternalTestClusterTests.java
Outdated
Show resolved
Hide resolved
| if (autoManageMinMasterNodes) { | ||
| return allNodesSettings; | ||
| } | ||
| return addBootstrapConfiguration(new Random(bootstrapNodeSelectionSeed), allNodesSettings); |
There was a problem hiding this comment.
why not just random() here?
There was a problem hiding this comment.
We run this twice with the same seed to verify that the behaviour is deterministic, but that seed does not affect the randomness supplied by random().
|
@elasticmachine please run the Gradle build tests 1 |
DaveCTurner
deleted the
2019-01-04-remove-initial-master-node-count-setting
branch
The
cluster.unsafe_initial_master_node_countsetting was introduced as atemporary measure while the design of
cluster.initial_master_nodeswas beingfinalised. This commit removes this temporary setting, replacing it with usages
of
cluster.initial_master_nodeswhere appropriate.