[FEATURE][ML] Add checksum checks on dataframe result joining #37259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core |
|
This is the java side of elastic/ml-cpp#358 |
benwtrent
reviewed
Jan 9, 2019
.../ml/src/main/java/org/elasticsearch/xpack/ml/analytics/process/AnalyticsResultProcessor.java
Outdated
Show resolved
Hide resolved
dimitris-athanasiou
changed the title
|
I've pushed a commit to actually use a checksum of all relevant values instead of just the document id. |
In order to sanity check that analytics results are joined correctly with their corresponding dataframe rows, we write a 32-bit hash of the document ids to the c++ process which includes it in the results. Upon joining we check the id hashes match.
dimitris-athanasiou
force-pushed
the
add-id-hash-checks-on-data-frame-result-joining
branch
from
13bd906 to
c04fa60
Compare
dimitris-athanasiou
deleted the
add-id-hash-checks-on-data-frame-result-joining
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to sanity check that analytics results are joined
correctly with their corresponding dataframe rows, we write
a 32-bit hash of the document ids to the c++ process which
includes it in the results. Upon joining we check the id
hashes match.