Fix InternalEngineTests#assertOpsOnPrimary #37746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The assertion `assertOpsOnPrimary` does not store seq_no and primary term of successful deletes to the `lastOpSeqNo` and `lastOpTerm`. This leads to failures of the subsequence CAS deletes or indexes with seq_no and term. Moreover, this assertion trips a translog assertion because it bumps the primary term of some operations but not the primary term of the engine. Relates elastic#36467 Closes elastic#37684
dnhatn
added
>test
|
Pinging @elastic/es-distributed |
|
run elasticsearch-ci/default-distro |
ywelsch
approved these changes
Jan 23, 2019
dnhatn
added a commit
that referenced
this pull request
Jan 28, 2019
The assertion `assertOpsOnPrimary` does not store seq_no and primary term of successful deletes to the `lastOpSeqNo` and `lastOpTerm`. This leads to failures of the subsequence CAS deletes or indexes with seq_no and term. Moreover, this assertion trips a translog assertion because it bumps the primary term of some operations but not the primary term of the engine. Relates #36467 Closes #37684
talevy
pushed a commit
to talevy/elasticsearch
that referenced
this pull request
Feb 15, 2019
The assertion `assertOpsOnPrimary` does not store seq_no and primary term of successful deletes to the `lastOpSeqNo` and `lastOpTerm`. This leads to failures of the subsequence CAS deletes or indexes with seq_no and term. Moreover, this assertion trips a translog assertion because it bumps the primary term of some operations but not the primary term of the engine. Relates elastic#36467 Closes elastic#37684
|
I do not think this was ever backported to the 6.6 branch, opened #38990 to do that |
talevy
added a commit
that referenced
this pull request
Feb 16, 2019
The assertion `assertOpsOnPrimary` does not store seq_no and primary term of successful deletes to the `lastOpSeqNo` and `lastOpTerm`. This leads to failures of the subsequence CAS deletes or indexes with seq_no and term. Moreover, this assertion trips a translog assertion because it bumps the primary term of some operations but not the primary term of the engine. Relates #36467 Closes #37684
kovrus
added a commit
to crate/crate
that referenced
this pull request
Sep 6, 2019
5 tasks
kovrus
added a commit
to crate/crate
that referenced
this pull request
Sep 6, 2019
mergify bot
pushed a commit
to crate/crate
that referenced
this pull request
Oct 25, 2019
Backport of elastic/elasticsearch#37746 (cherry picked from commit 1ec2443) # Conflicts: # es/es-testing/src/main/java/org/elasticsearch/index/engine/EngineTestCase.java
seut
pushed a commit
to crate/crate
that referenced
this pull request
Oct 25, 2019
Backport of elastic/elasticsearch#37746 (cherry picked from commit 1ec2443)
mergify bot
pushed a commit
to crate/crate
that referenced
this pull request
Oct 25, 2019
Backport of elastic/elasticsearch#37746 (cherry picked from commit 1ec2443)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The assertion
assertOpsOnPrimarydoes not store seq_no and primaryterm of successful deletes to the
lastOpSeqNoandlastOpTerm. Thisleads to failures of the subsequent CAS deletes or indexes with seq_no
and term. Moreover, this assertion trips a translog assertion because it
bumps the primary term of some operations but does not the primary term
of the engine.
Relates #36467
Closes #37684