Re-enable accounting breaker check in InternalTestCluster #38131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakrone
added
>test
|
Pinging @elastic/es-core-infra |
|
@dakrone IIUC this PR only enables the accounting circuit breaker again but does not attempt to fix the underlying issue. Is the intention behind this change to get it to fail in CI so you can analyze this? Can you please update the PR description accordingly to document the intention? |
danielmitterdorfer
added
:Core/Infra/Circuit Breakers
|
@danielmitterdorfer that's correct, I've updated the description. |
danielmitterdorfer
approved these changes
Feb 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #30290
The intent for this is to see whether this failure still happens, and if so, provide more up-to-date logs for analysis.