Skip to content

Decrease leader and follower check timeout #38298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2019
Merged

Decrease leader and follower check timeout #38298

merged 1 commit into from
Feb 4, 2019

Conversation

ywelsch
Copy link
Contributor

@ywelsch ywelsch commented Feb 4, 2019

Reduces the leader and follower check timeout to 3 * 10 = 30s instead of 3 * 30 = 90s, with 30s still being a very long time for a node to be completely unresponsive.

@ywelsch ywelsch added >non-issue v7.0.0 :Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. labels Feb 4, 2019
@ywelsch ywelsch requested a review from DaveCTurner February 4, 2019 07:52
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@ywelsch
Copy link
Contributor Author

ywelsch commented Feb 4, 2019

@elasticmachine run elasticsearch-ci/1 please

DaveCTurner
DaveCTurner approved these changes Feb 4, 2019
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ywelsch ywelsch merged commit ece8c65 into elastic:master Feb 4, 2019
@ywelsch ywelsch mentioned this pull request Feb 4, 2019
Closed
61 tasks
@ywelsch ywelsch mentioned this pull request Feb 25, 2019
Merged
ywelsch added a commit that referenced this pull request Mar 11, 2019
@ywelsch
Fix CoordinatorTests.testIncompatibleDiffResendsFullState (#39345)
33e2cff 
This test started failing since decreasing the leader and follower check timeouts (#38298). The
reason is that the test was relying on the default publication timeout to come into effect before
leader / follower check timeouts, which is now not always true anymore.

Closes #38867
ywelsch added a commit that referenced this pull request Mar 11, 2019
@ywelsch
Fix CoordinatorTests.testIncompatibleDiffResendsFullState (#39345)
292eb8b 
This test started failing since decreasing the leader and follower check timeouts (#38298). The
reason is that the test was relying on the default publication timeout to come into effect before
leader / follower check timeouts, which is now not always true anymore.

Closes #38867
ywelsch added a commit that referenced this pull request Mar 11, 2019
@ywelsch
Fix CoordinatorTests.testIncompatibleDiffResendsFullState (#39345)
74553f9 
This test started failing since decreasing the leader and follower check timeouts (#38298). The
reason is that the test was relying on the default publication timeout to come into effect before
leader / follower check timeouts, which is now not always true anymore.

Closes #38867
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaveCTurner DaveCTurner DaveCTurner approved these changes

Assignees
No one assigned
Labels
:Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. >non-issue v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ywelsch @elasticmachine @DaveCTurner @colings86