Fix typos in Field-Caps documentation #38580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colings86
added
the
:Search Foundations/Mapping
|
Pinging @elastic/es-search |
cbuescher
requested changes
Feb 11, 2019
|
|
||
| [source,js] | ||
| -------------------------------------------------- | ||
| GET _field_caps?fields=rating | ||
| -------------------------------------------------- | ||
| // CONSOLE | ||
|
|
||
| ... but the request can also be restricted to specific indices: | ||
| ...but the request can also be restricted to specific indices: |
There was a problem hiding this comment.
How about omitting the dots altogether, starting a new sentence with "The requestst can...". I think that would be much better.
There was a problem hiding this comment.
I agree -- good suggestion. I'll make the change.
Reworded because asciidoc was formatting the ellipse/space as a numbered list.
|
@elasticmachine test this please |
cbuescher
pushed a commit
that referenced
this pull request
Feb 11, 2019
Fix typo in Field-Caps documentation Reworded because asciidoc was formatting the ellipse/space as a numbered list.
cbuescher
pushed a commit
that referenced
this pull request
Feb 11, 2019
Fix typo in Field-Caps documentation Reworded because asciidoc was formatting the ellipse/space as a numbered list.
cbuescher
pushed a commit
that referenced
this pull request
Feb 11, 2019
Fix typo in Field-Caps documentation Reworded because asciidoc was formatting the ellipse/space as a numbered list.
cbuescher
pushed a commit
that referenced
this pull request
Feb 11, 2019
Fix typo in Field-Caps documentation Reworded because asciidoc was formatting the ellipse/space as a numbered list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.