Fix CloseWhileRelocatingShardsIT #38728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlrx
added
>test
|
Pinging @elastic/es-distributed |
ywelsch
approved these changes
Feb 12, 2019
|
Thanks @ywelsch |
tlrx
added a commit
that referenced
this pull request
Feb 12, 2019
tlrx
added a commit
that referenced
this pull request
Feb 12, 2019
tlrx
added a commit
that referenced
this pull request
Feb 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sadly I didn't notice in #38159 that the test
CloseWhileRelocatingShardsITwas reusing multiple instances ofSendRequestBehaviorfor the same transport service address. This is wrong because only the last behavior configured for the transport service address will be effectively used.This pull request changes the
CloseWhileRelocatingShardsITso that a singleSendRequestBehavioris used in the test to block and hold on start recovery requests. It also allows recoveries to be interrupted (which is the case when the shard is closed) and records interrupted recoveries to later check that the index is effectively closed.Closes #38090