Skip to content

Simplify AutoFollowCoordinator with GroupedListener #39603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2019

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Mar 2, 2019

This change simplifies AutoFollowCoordinator by replacing a combination of AtomicArray and CountDown with GroupedActionListener.

@dnhatn dnhatn added >non-issue :Distributed Indexing/CCR Issues around the Cross Cluster State Replication features v8.0.0 v7.2.0 labels Mar 2, 2019
@dnhatn dnhatn requested a review from martijnvg March 2, 2019 17:36
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DaveCTurner
Copy link
Contributor

TIL GroupedActionListener ❤️

@dnhatn
Copy link
Member Author

dnhatn commented Mar 4, 2019

Thanks @martijnvg for reviewing.

@dnhatn dnhatn merged commit 93034af into elastic:master Mar 4, 2019
@dnhatn dnhatn deleted the autofollow-group-listener branch March 4, 2019 17:47
dnhatn added a commit that referenced this pull request Mar 4, 2019
This change simplifies AutoFollowCoordinator by replacing a combination
of AtomicArray and CountDown with GroupedActionListener.
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/CCR Issues around the Cross Cluster State Replication features >non-issue v7.2.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants