Add version to prebuilt analyzers #3966
Conversation
|
am I correct in the fact that we just cache the analyzers for the current version, and if the version is not CURRENT, then we create a new instance each time? If so: First, this is not very evident in terms of design in the The other part is that if someone upgrades, for example, from 0.90.5 to 0.90.6, then all the other indices in previous versions will now create all the analyzers for all the different indices on that version (0.90.5). I was thinking that |
|
Ahh, I missed the fact that we have the cache on the enum itself. 2 things that I think are still problematic, will comment over it. |
| Version indexVersion = settings.getAsVersion(IndexMetaData.SETTING_VERSION_CREATED, Version.CURRENT); | ||
| if (!Version.CURRENT.equals(indexVersion)) { | ||
| Analyzer analyzer = PreBuiltAnalyzers.valueOf(name.toUpperCase(Locale.ROOT)).getAnalyzer(indexVersion); | ||
| return new PreBuiltAnalyzerProvider(name, AnalyzerScope.INDEX, analyzer); |
There was a problem hiding this comment.
this should not be AnalyzerScope.INDEX, cause its cached on the enum level, so the scope should probably AnalyzerScope.INDICES. I would simply use the scope provided in the constructor (which will be the INDICES one).
|
Updated: Set the Scope to |
|
@spinscale maybe we should have a test that creates and closes indices randomly and makes sure we don't get the Scope wrong in the future. I think such a test would be very helpful! |
This patch takes the version of the created index into account when a prebuilt analyzer is created. So, if an index was created with 0.90.4, then the prebuilt analyzers will be the same than on the 0.90.4 release. One reason for this feature is the possibility to change pre built analyzers like the standard one. The patch tries to reuse analyzers as mutch as possible. So even if version X.Y.Z and X.Y.A use the same lucene analyzers, the same instance is reused in order to prevent overcreation of lucene analyzer instances. Closes elastic#3790
This patch takes the version of the created index into account when a
prebuilt analyzer is created.
So, if an index was created with 0.90.4, then the prebuilt analyzers
will be the same than on the 0.90.4 release.
One reason for this feature is the possibility to change pre built
analyzers like the standard one.
The patch tries to reuse analyzers as mutch as possible. So even if
version X.Y.Z and X.Y.A use the same lucene analyzers, the same instance
is reused in order to prevent overcreation of lucene analyzer instances.
Closes #3790