Avoid copying the field alias lookup structure unnecessarily. #39726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The field alias map is now only copied if a new alias is added, or if an alias definition has changed. This follows the same behavior as we have for concrete field mappings and avoids unnecessary object creation.
jtibshirani
added
>bug
:Search Foundations/Mapping
|
Pinging @elastic/es-search |
cbuescher
reviewed
Mar 12, 2019
server/src/main/java/org/elasticsearch/index/mapper/FieldTypeLookup.java
Show resolved
Hide resolved
|
@elasticmachine run elasticsearch-ci/bwc |
|
Thanks @cbuescher for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The field alias map is now only copied if a new alias is added, or if an alias
definition has changed. This follows the same behavior as we have for concrete
field mappings and avoids unnecessary object creation.