-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Fix token Invalidation when retries exhausted #39799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix token Invalidation when retries exhausted #39799
Conversation
Pinging @elastic/es-security |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
both https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+pull-request+default-distro/8166/consoleFull and https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+pull-request-bwc/1448/consoleFull are plagued by:
In a multitude of independent tests. I'm going to assume a transient network failure. |
@elasticmachine run elasticsearch-ci/default-distro |
@elasticmachine run elasticsearch-ci/bwc |
The failures were utterly alien and I think they were due to the #39512 missing in the PR . I have merged master in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@elasticmachine run elasticsearch-ci/bwc |
For https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+pull-request-bwc/1539/console
I have raised https://github.com/elastic/infra/issues/9993 |
Fixes an error about missing to call the index invalidation listener when retry count is exhausted but there are still tokens to be retried.
Fixes a glitch that misses to call the index invalidation listener, when retry count is exhausted and there are still tokens to be retried.
I recommend the split diff to better visualize the change