SQL: ConstantProcessor can now handle NamedWriteable #39876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-search |
Enhance ConstantProcessor to properly serialize complex objects (Intervals) that have their own custom serialization/deserialization mechanism Fix elastic#39875 Update test
|
run elasticsearch-ci/packaging-sample |
astefan
reviewed
Mar 11, 2019
| @@ -28,7 +31,10 @@ protected ConstantProcessor createTestInstance() { | |||
|
|
|||
| @Override | |||
| protected ConstantProcessor mutateInstance(ConstantProcessor instance) throws IOException { | |||
| return new ConstantProcessor(randomValueOtherThan(instance.process(null), () -> randomAlphaOfLength(5))); | |||
| return new ConstantProcessor(randomValueOtherThan(instance.process(null), | |||
There was a problem hiding this comment.
Why not also keeping the original randomAlphaOfLength? Using a randomBoolean you could switch between randomAlphaOfLength and an IntervalDayTime instance.
There was a problem hiding this comment.
Because the randomAlpha is already tested from the initial instance which gets serialized/deserialized so using it again wouldn't change much.
astefan
approved these changes
Mar 11, 2019
costin
added a commit
that referenced
this pull request
Mar 11, 2019
Enhance ConstantProcessor to properly serialize complex objects (Intervals) that have their own custom serialization/deserialization mechanism Fix #39875
costin
added a commit
that referenced
this pull request
Mar 11, 2019
costin
added a commit
that referenced
this pull request
Mar 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance ConstantProcessor to properly serialize complex objects
(Intervals) that have their own custom serialization/deserialization
mechanism
Fix #39875