Always fail engine if delete operation fails #40117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
>enhancement
:Distributed Indexing/Engine
|
Pinging @elastic/es-distributed |
|
test this please |
s1monw
approved these changes
Mar 18, 2019
| } else { | ||
| throw ex; | ||
| } | ||
| assert indexWriter.getTragicException() != null : "delete operation should never fail at document level"; |
There was a problem hiding this comment.
can we do this like this:
if (indexWriter.getTragicException() == null) {
throw new AssertionError("delete operation should never fail at document level", ex);
}we otherwise loose the original exception and then we are in trouble :)
|
Thanks @s1monw! |
dnhatn
added a commit
that referenced
this pull request
Mar 19, 2019
Unlike index operations which can fail at the document level to analyzing errors, delete operations should never fail at the document level whether soft-deletes is enabled or not. With this change, we will always fail the engine if we fail to apply a delete operation to Lucene. Closes #33256
kovrus
added a commit
to crate/crate
that referenced
this pull request
Sep 2, 2019
Backport of elastic/elasticsearch#40117 With this change, we will always fail the engine if we fail to apply a delete operation to Lucene.
kovrus
added a commit
to crate/crate
that referenced
this pull request
Sep 3, 2019
Backport of elastic/elasticsearch#40117 With this change, we will always fail the engine if we fail to apply a delete operation to Lucene.
5 tasks
kovrus
added a commit
to crate/crate
that referenced
this pull request
Sep 3, 2019
Backport of elastic/elasticsearch#40117 With this change, we will always fail the engine if we fail to apply a delete operation to Lucene.
5 tasks
kovrus
added a commit
to crate/crate
that referenced
this pull request
Sep 3, 2019
Backport of elastic/elasticsearch#40117 With this change, we will always fail the engine if we fail to apply a delete operation to Lucene.
mergify bot
pushed a commit
to crate/crate
that referenced
this pull request
Sep 3, 2019
Backport of elastic/elasticsearch#40117 With this change, we will always fail the engine if we fail to apply a delete operation to Lucene.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike index operations which can fail at the document level to analyzing errors, delete operations should never fail at the document level whether soft-deletes is enabled or not. With this change, we will always fail the engine if we fail to apply a delete operation to Lucene.
Closes #33256