[ML] Add integration tests to check persistence #40272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional checks have been added to exercise the behaviour of persistence on graceful close of an anomaly job. In particular: - check that persistence does not occur for a job that is opened and then immediately closed, with nothing else having happened. - check that persistence occurs on graceful close of a job if it has processed data. - check that persistence occurs subsequent to time being manually advanced - even if no additional data has been seen by the job - check the edge case where persistence occurs if a job is opened, time is manually advanced and then the job is closed, having seen no data. Related to elastic/ml-cpp#393
|
Pinging @elastic/ml-core |
…t_state_on_graceful_job_close
|
Jenkins retest this please |
|
Jenkins retest this please |
edsavage
added a commit
to edsavage/elasticsearch
that referenced
this pull request
Mar 21, 2019
Additional checks have been added to exercise the behaviour of persistence on graceful close of an anomaly job. In particular: - check that persistence does not occur for a job that is opened and then immediately closed, with nothing else having happened. - check that persistence occurs on graceful close of a job if it has processed data. - check that persistence occurs subsequent to time being manually advanced - even if no additional data has been seen by the job - check the edge case where persistence occurs if a job is opened, time is manually advanced and then the job is closed, having seen no data. Related to elastic/ml-cpp#393
edsavage
added a commit
to edsavage/elasticsearch
that referenced
this pull request
Mar 21, 2019
Additional checks have been added to exercise the behaviour of persistence on graceful close of an anomaly job. In particular: - check that persistence does not occur for a job that is opened and then immediately closed, with nothing else having happened. - check that persistence occurs on graceful close of a job if it has processed data. - check that persistence occurs subsequent to time being manually advanced - even if no additional data has been seen by the job - check the edge case where persistence occurs if a job is opened, time is manually advanced and then the job is closed, having seen no data. Related to elastic/ml-cpp#393
This was referenced Mar 21, 2019
edsavage
added a commit
that referenced
this pull request
Mar 21, 2019
Additional checks to exercise the behaviour of persistence on graceful close of an anomaly job. Related to elastic/ml-cpp#393 Backports #40272
edsavage
added a commit
that referenced
this pull request
Mar 21, 2019
Additional checks to exercise the behaviour of persistence on graceful close of an anomaly job Related to elastic/ml-cpp#393 Backports #40272
edsavage
added a commit
that referenced
this pull request
Mar 21, 2019
Additional checks to exercise the behaviour of persistence on graceful close of an anomaly job. Related to elastic/ml-cpp#393 Backports #40272
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional checks have been added to exercise the behaviour of
persistence on graceful close of an anomaly job. In particular:
then immediately closed, with nothing else having happened.
processed data.
advanced - even if no additional data has been seen by the job
is manually advanced and then the job is closed, having seen no data.
Related to elastic/ml-cpp#393