-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Update getting-started.asciidoc #40393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hits.sort contain values not keys { "_index" : "bank", "_type" : "_doc", "_id" : "1", "_score" : null, "_source" : { "account_number" : *1*, "balance" : 39225, "firstname" : "Amber", "lastname" : "Duke", "age" : 32, "gender" : "M", "address" : "880 Holmes Lane", "employer" : "Pyrami", "email" : "[email protected]", "city" : "Brogan", "state" : "IL" }, "sort" : [ *1* ] }, { "_index" : "bank", "_type" : "_doc", "_id" : "2", "_score" : null, "_source" : { "account_number" : *2*, "balance" : 28838, "firstname" : "Roberta", "lastname" : "Bender", "age" : 22, "gender" : "F", "address" : "560 Kingsway Place", "employer" : "Chillium", "email" : "[email protected]", "city" : "Bennett", "state" : "LA" }, "sort" : [ *2* ] },
Pinging @elastic/es-docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @magnusram05, thanks for taking an interest in the getting-started docs. I left a small comment which might even improve upon your suggested edit. If you agree just push the change and I can run the tests and merge.
@@ -788,7 +788,7 @@ As for the response, we see the following parts: | |||
* `hits` – search results | |||
* `hits.total` – total number of documents matching our search criteria | |||
* `hits.hits` – actual array of search results (defaults to first 10 documents) | |||
* `hits.sort` - sort key for results (missing if sorting by score) | |||
* `hits.sort` - sort value for results (missing if sorting by score) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you really want to be fussy, it could probably be "value of the sort key for each result"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made the changes.
hi @magnusram05 do you plan on updating your PR based on the comment above? |
Hi,
I will merge it ASAP.
Regards,
Ram
…On Mon, 15 Jul, 2019, 15:19 Luca Cavanna, ***@***.***> wrote:
hi @magnusram05 <https://github.com/magnusram05> do you plan on updating
your PR based on the comment above?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#40393?email_source=notifications&email_token=AKWHRRPLDRVSJGMFUV5JMNDP7RBZDA5CNFSM4HAUBVI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ5GPCA#issuecomment-511338376>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AKWHRROXKQILRVGZ276POSTP7RBZDANCNFSM4HAUBVIQ>
.
|
Fixed review comment
@elasticmachine test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the change, LGTM.
I will merge this to 6.6 and later branches.
@elasticmachine update branch |
@elasticmachine test this please |
@magnusram05 thanks for the change, I merged it to all relevant branches. |
Thanks. Appreciate it.
This is my first open source contribution. :)
Regards,
Ram
…On Tue, 16 Jul, 2019, 17:17 Christoph Büscher, ***@***.***> wrote:
@magnusram05 <https://github.com/magnusram05> thanks for the change, I
merged it to all relevant branches.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#40393?email_source=notifications&email_token=AKWHRRP2C5Q3IZ2B3PQ7ZTDP7WYNJA5CNFSM4HAUBVI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2ASWVI#issuecomment-511781717>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AKWHRRNEWGS53U6IDIAGC6TP7WYNJANCNFSM4HAUBVIQ>
.
|
hits.sort contain values not keys
gradle check
?