Remove dynamic objects from security index #40499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The security index had a few "object" types with "dynamic": true However, this automatically creates a mapping for each field that is created within those objects. This means that types are dynamically inferred and "locked in" for future updates. Instead we want "dynamic": false which will allow us to store a range of fields in these nested objects and retrieve them from the source, without creating mapping types for those fields.
tvernum
added
>bug
v7.0.0
:Security/Security
|
Pinging @elastic/es-security |
|
@jaymode Do you remember why we set |
|
This ends up being a trivial change because it's safe to change an index mapping to set So this change doesn't fix the problem 100% because existing security indices might have some incorrect dynamic mappings, but it stops the problem from getting worse. |
I do not recall the reasoning. |
tvernum
added a commit
to tvernum/elasticsearch
that referenced
this pull request
Apr 2, 2019
The security index had a few "object" types with "dynamic": true However, this automatically creates a mapping for each field that is created within those objects. This means that types are dynamically inferred and "locked in" for future updates. Instead we want "dynamic": false which will allow us to store a range of fields in these nested objects and retrieve them from the source, without creating mapping types for those fields. Backport of: elastic#40499
tvernum
added a commit
that referenced
this pull request
Apr 5, 2019
The security index had a few "object" types with "dynamic": true However, this automatically creates a mapping for each field that is created within those objects. This means that types are dynamically inferred and "locked in" for future updates. Instead we want "dynamic": false which will allow us to store a range of fields in these nested objects and retrieve them from the source, without creating mapping types for those fields. Backport of: #40499
tvernum
added a commit
to tvernum/elasticsearch
that referenced
this pull request
Apr 5, 2019
The security index had a few "object" types with "dynamic": true However, this automatically creates a mapping for each field that is created within those objects. This means that types are dynamically inferred and "locked in" for future updates. Instead we want "dynamic": false which will allow us to store a range of fields in these nested objects and retrieve them from the source, without creating mapping types for those fields. Backport of: elastic#40499
tvernum
added a commit
that referenced
this pull request
Apr 15, 2019
The security index had a few "object" types with "dynamic": true However, this automatically creates a mapping for each field that is created within those objects. This means that types are dynamically inferred and "locked in" for future updates. Instead we want "dynamic": false which will allow us to store a range of fields in these nested objects and retrieve them from the source, without creating mapping types for those fields. Backport of: #40499
tvernum
added a commit
to tvernum/elasticsearch
that referenced
this pull request
May 7, 2019
The security index had a few "object" types with "dynamic": true However, this automatically creates a mapping for each field that is created within those objects. This means that types are dynamically inferred and "locked in" for future updates. Instead we want "dynamic": false which will allow us to store a range of fields in these nested objects and retrieve them from the source, without creating mapping types for those fields. Backport of: elastic#40499
tvernum
added a commit
that referenced
this pull request
May 7, 2019
The security index had a few "object" types with "dynamic": true However, this automatically creates a mapping for each field that is created within those objects. This means that types are dynamically inferred and "locked in" for future updates. Instead we want "dynamic": false which will allow us to store a range of fields in these nested objects and retrieve them from the source, without creating mapping types for those fields. Backport of: #40499
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
The security index had a few "object" types with "dynamic": true However, this automatically creates a mapping for each field that is created within those objects. This means that types are dynamically inferred and "locked in" for future updates. Instead we want "dynamic": false which will allow us to store a range of fields in these nested objects and retrieve them from the source, without creating mapping types for those fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The security index had a few "object" types with
However, this automatically creates a mapping for each field that is
created within those objects. This means that types are dynamically
inferred and "locked in" for future updates.
Instead we want "dynamic": false which will allow us to store a range
of fields in these nested objects and retrieve them from the source,
without creating mapping types for those fields.
Closes: #35460