Add Repository Consistency Assertion to SnapshotResiliencyTests #40857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add some quick validation on not leaving behind any dangling metadata or dangling indices to the snapshot resiliency tests * Added todo about expanding this assertion further
original-brownbear
added
>non-issue
>test
|
Pinging @elastic/es-distributed |
andrershov
suggested changes
Apr 16, 2019
| * Assert that there are no unreferenced indices or unreferenced root-level metadata blobs in any repository. | ||
| * TODO: Expand the logic here to also check for unreferenced segment blobs and shard level metadata | ||
| */ | ||
| private void assertNoStaleRepositoryData() throws IOException { |
There was a problem hiding this comment.
I prefer to split this method into separate methods and give them reasonable names, such as assertSnapshotUUIDs, assertIndexUUIDs, etc.
There was a problem hiding this comment.
sure extracted those methods :)
| testClusterNodes.nodes.values().forEach(TestClusterNode::stop); | ||
| public void stopServices() throws IOException { | ||
| try { | ||
| assertNoStaleRepositoryData(); |
There was a problem hiding this comment.
Can we have two After methods - the first one stopServices, the second one - assertNoStaleRepositoryData?
Even if we can have only one after method it probably makes sense to rename it.
There was a problem hiding this comment.
Renamed it, can't really use another after here since I need to validate consistency before closing the services since that deletes the files.
|
@andrershov thanks for taking a look, addressed both points :) |
|
thanks @andrershov |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Apr 29, 2019
…tic#40857) * Add Repository Consistency Assertion to SnapshotResiliencyTests * Add some quick validation on not leaving behind any dangling metadata or dangling indices to the snapshot resiliency tests * Added todo about expanding this assertion further
original-brownbear
added a commit
that referenced
this pull request
Apr 29, 2019
* Add Repository Consistency Assertion to SnapshotResiliencyTests (#40857) * Add Repository Consistency Assertion to SnapshotResiliencyTests * Add some quick validation on not leaving behind any dangling metadata or dangling indices to the snapshot resiliency tests * Added todo about expanding this assertion further * Fix SnapshotResiliencyTest Repo Consistency Check (#41332) * Fix SnapshotResiliencyTest Repo Consistency Check * Due to the random creation of an empty `extra0` file by the Lucene mockFS we see broken tests because we use the existence of an index folder in assertions and the index deletion doesn't go through if there are extra files in an index folder * Fixed by removing the `extra0` file and resulting empty directory trees before asserting repo consistency * Closes #41326 * Reenable SnapshotResiliency Test (#41437) This was fixed in #41332 but I forgot to reenable the test. * fix compile on java8
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
…tic#40857) * Add Repository Consistency Assertion to SnapshotResiliencyTests * Add some quick validation on not leaving behind any dangling metadata or dangling indices to the snapshot resiliency tests * Added todo about expanding this assertion further
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.datthere :)I just figured I'd add this real quick as it was easy to add and might help spot issues quicker now that we're refactoring the deletes more and more.