Short-circuit rebalancing when disabled #40942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today if `cluster.routing.rebalance.enable: none` then rebalancing is disabled, but we still execute `balanceByWeights()` and perform some rather expensive calculations before discovering that we cannot rebalance any shards. In a large cluster this can make cluster state updates occur rather slowly. With this change we check earlier whether rebalancing is globally disabled and, if so, avoid the rebalancing process entirely.
DaveCTurner
added
>bug
:Distributed Coordination/Allocation
|
Pinging @elastic/es-distributed |
original-brownbear
approved these changes
Apr 8, 2019
.../org/elasticsearch/cluster/routing/allocation/decider/EnableAllocationShortCircuitTests.java
Outdated
Show resolved
Hide resolved
.../org/elasticsearch/cluster/routing/allocation/decider/EnableAllocationShortCircuitTests.java
Outdated
Show resolved
Hide resolved
.../org/elasticsearch/cluster/routing/allocation/decider/EnableAllocationShortCircuitTests.java
Outdated
Show resolved
Hide resolved
henningandersen
requested changes
Apr 8, 2019
| } | ||
|
|
||
| for (IndexMetaData indexMetaData : allocation.metaData()) { | ||
| if (INDEX_ROUTING_REBALANCE_ENABLE_SETTING.exists(indexMetaData.getSettings())) { |
There was a problem hiding this comment.
Would it make sense to also be able to short circuit if that setting is set to Rebalance.NONE?
There was a problem hiding this comment.
Ok, I added this in 0c5c04b. I don't think this is a common configuration, so it'd be ok either way.
|
|
||
| ClusterState clusterState = ClusterState.builder(ClusterName.CLUSTER_NAME_SETTING.get(Settings.EMPTY)) | ||
| .nodes(DiscoveryNodes.builder().add(newNode("node1"))).build(); | ||
|
|
There was a problem hiding this comment.
I think it makes sense to also add some indices in this test case?
There was a problem hiding this comment.
Sort of, although then we have to allocate their shards or else the ClusterRebalanceAllocationDecider steps in and prevents rebalancing. I expanded the tests to do this.
|
@elasticmachine run elasticsearch-ci/2 |
henningandersen
approved these changes
Apr 8, 2019
DaveCTurner
added a commit
that referenced
this pull request
Apr 8, 2019
Today if `cluster.routing.rebalance.enable: none` then rebalancing is disabled, but we still execute `balanceByWeights()` and perform some rather expensive calculations before discovering that we cannot rebalance any shards. In a large cluster this can make cluster state updates occur rather slowly. With this change we check earlier whether rebalancing is globally disabled and, if so, avoid the rebalancing process entirely.
DaveCTurner
added a commit
that referenced
this pull request
Apr 8, 2019
Today if `cluster.routing.rebalance.enable: none` then rebalancing is disabled, but we still execute `balanceByWeights()` and perform some rather expensive calculations before discovering that we cannot rebalance any shards. In a large cluster this can make cluster state updates occur rather slowly. With this change we check earlier whether rebalancing is globally disabled and, if so, avoid the rebalancing process entirely.
DaveCTurner
deleted the
2019-04-08-short-circuit-allocation-when-disabled
branch
DaveCTurner
added a commit
that referenced
this pull request
Apr 8, 2019
Today if `cluster.routing.rebalance.enable: none` then rebalancing is disabled, but we still execute `balanceByWeights()` and perform some rather expensive calculations before discovering that we cannot rebalance any shards. In a large cluster this can make cluster state updates occur rather slowly. With this change we check earlier whether rebalancing is globally disabled and, if so, avoid the rebalancing process entirely.
DaveCTurner
added a commit
that referenced
this pull request
Apr 8, 2019
This reverts commit b53488e.
DaveCTurner
added a commit
that referenced
this pull request
Apr 8, 2019
This reverts commit 4544b29.
DaveCTurner
added a commit
that referenced
this pull request
Apr 8, 2019
This reverts commit f78e6ef.
DaveCTurner
added a commit
that referenced
this pull request
Apr 8, 2019
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Apr 8, 2019
Today if `cluster.routing.rebalance.enable: none` then rebalancing is disabled, but we still execute `balanceByWeights()` and perform some rather expensive calculations before discovering that we cannot rebalance any shards. In a large cluster this can make cluster state updates occur rather slowly. With this change we check earlier whether rebalancing is globally disabled and, if so, avoid the rebalancing process entirely. Relates elastic#40942 which was reverted because of egregiously faulty tests.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Apr 8, 2019
…e-unsafe-publication * elastic/master: Update contributing docs to reflect JDK 11 (elastic#40955) Docs: Simplifying setup by using module configuration variant syntax (elastic#40879) Unmute CreateIndexIT testCreateAndDeleteIndexConcurrently CI failures (elastic#40960) Revert "Short-circuit rebalancing when disabled (elastic#40942)" Mute EnableAllocationShortCircuitTests SQL: Refactor args verification of In & conditionals (elastic#40916) Avoid sharing source directories as it breaks intellij (elastic#40877) Short-circuit rebalancing when disabled (elastic#40942) SQL: Prefer resultSets over exceptions in metadata (elastic#40641) Mute ClusterPrivilegeTests.testThatSnapshotAndRestore Fix Race in AsyncTwoPhaseIndexerTests.testStateMachine (elastic#40947) Relax Overly Strict Assertion in TransportShardBulkAction (elastic#40940)
DaveCTurner
added a commit
that referenced
this pull request
Apr 9, 2019
Today if `cluster.routing.rebalance.enable: none` then rebalancing is disabled, but we still execute `balanceByWeights()` and perform some rather expensive calculations before discovering that we cannot rebalance any shards. In a large cluster this can make cluster state updates occur rather slowly. With this change we check earlier whether rebalancing is globally disabled and, if so, avoid the rebalancing process entirely. Relates #40942 which was reverted because of egregiously faulty tests.
DaveCTurner
added a commit
that referenced
this pull request
Apr 9, 2019
Today if `cluster.routing.rebalance.enable: none` then rebalancing is disabled, but we still execute `balanceByWeights()` and perform some rather expensive calculations before discovering that we cannot rebalance any shards. In a large cluster this can make cluster state updates occur rather slowly. With this change we check earlier whether rebalancing is globally disabled and, if so, avoid the rebalancing process entirely. Relates #40942 which was reverted because of egregiously faulty tests.
DaveCTurner
added a commit
that referenced
this pull request
Apr 9, 2019
Today if `cluster.routing.rebalance.enable: none` then rebalancing is disabled, but we still execute `balanceByWeights()` and perform some rather expensive calculations before discovering that we cannot rebalance any shards. In a large cluster this can make cluster state updates occur rather slowly. With this change we check earlier whether rebalancing is globally disabled and, if so, avoid the rebalancing process entirely. Relates #40942 which was reverted because of egregiously faulty tests.
DaveCTurner
added a commit
that referenced
this pull request
Apr 9, 2019
Today if `cluster.routing.rebalance.enable: none` then rebalancing is disabled, but we still execute `balanceByWeights()` and perform some rather expensive calculations before discovering that we cannot rebalance any shards. In a large cluster this can make cluster state updates occur rather slowly. With this change we check earlier whether rebalancing is globally disabled and, if so, avoid the rebalancing process entirely. Relates #40942 which was reverted because of egregiously faulty tests.
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
Today if `cluster.routing.rebalance.enable: none` then rebalancing is disabled, but we still execute `balanceByWeights()` and perform some rather expensive calculations before discovering that we cannot rebalance any shards. In a large cluster this can make cluster state updates occur rather slowly. With this change we check earlier whether rebalancing is globally disabled and, if so, avoid the rebalancing process entirely.
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
Today if `cluster.routing.rebalance.enable: none` then rebalancing is disabled, but we still execute `balanceByWeights()` and perform some rather expensive calculations before discovering that we cannot rebalance any shards. In a large cluster this can make cluster state updates occur rather slowly. With this change we check earlier whether rebalancing is globally disabled and, if so, avoid the rebalancing process entirely. Relates elastic#40942 which was reverted because of egregiously faulty tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today if
cluster.routing.rebalance.enable: nonethen rebalancing is disabled,but we still execute
balanceByWeights()and perform some rather expensivecalculations before discovering that we cannot rebalance any shards. In a large
cluster this can make cluster state updates occur rather slowly. With this
change we check earlier whether rebalancing is globally disabled and, if so,
avoid the rebalancing process entirely.