[DOCS] Fix broken links for 7.0 release #41036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrodewig
added
>docs
|
Pinging @elastic/es-core-infra |
jrodewig
commented
Apr 9, 2019
| @@ -279,7 +279,7 @@ shard will be allocated upon reopening the index. | |||
| [float] | |||
| === Use two phase commit for Cluster State publishing (STATUS: DONE, v5.0.0) | |||
|
|
|||
| A master node in Elasticsearch continuously https://www.elastic.co/guide/en/elasticsearch/reference/current/modules-discovery-zen.html#fault-detection[monitors the cluster nodes] | |||
| A master node in Elasticsearch continuously https://www.elastic.co/guide/en/elasticsearch/reference/current/cluster-fault-detection.html[monitors the cluster nodes] | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
I don't believe we have those attributes set up, no.
There was a problem hiding this comment.
It's just a matter of including the shared attributes...but I agree that it's not essential.
nik9000
approved these changes
Apr 9, 2019
| @@ -279,7 +279,7 @@ shard will be allocated upon reopening the index. | |||
| [float] | |||
| === Use two phase commit for Cluster State publishing (STATUS: DONE, v5.0.0) | |||
|
|
|||
| A master node in Elasticsearch continuously https://www.elastic.co/guide/en/elasticsearch/reference/current/modules-discovery-zen.html#fault-detection[monitors the cluster nodes] | |||
| A master node in Elasticsearch continuously https://www.elastic.co/guide/en/elasticsearch/reference/current/cluster-fault-detection.html[monitors the cluster nodes] | |||
There was a problem hiding this comment.
I don't believe we have those attributes set up, no.
|
Thanks @nik9000 ! |
debadair
suggested changes
Apr 9, 2019
| @@ -296,7 +296,7 @@ the change, it is committed and commit messages are sent to the nodes. See {GIT} | |||
|
|
|||
| During master election each node pings in order to discover other nodes and validate the liveness of existing | |||
| nodes. Based on this information the node either discovers an existing master or, if enough nodes are found | |||
| (see https://www.elastic.co/guide/en/elasticsearch/reference/current/modules-discovery-zen.html#master-election[`discovery.zen.minimum_master_nodes`]) a new master will be elected. Currently, the node that is | |||
| (`discovery.zen.minimum_master_nodes`) a new master will be elected. Currently, the node that is | |||
| elected as master will update the cluster state to indicate the result of the election. Other nodes will submit | |||
There was a problem hiding this comment.
Discovery has changed in 7.0 and the referenced setting is deprecated. Rather than simply removing the link, I'd remove the references to the discovery.zen.minimum_master_nodes setting and cross reference https://www.elastic.co/guide/en/elasticsearch/reference/7.0/modules-discovery-quorums.html#_master_elections for more information.
| @@ -279,7 +279,7 @@ shard will be allocated upon reopening the index. | |||
| [float] | |||
| === Use two phase commit for Cluster State publishing (STATUS: DONE, v5.0.0) | |||
|
|
|||
| A master node in Elasticsearch continuously https://www.elastic.co/guide/en/elasticsearch/reference/current/modules-discovery-zen.html#fault-detection[monitors the cluster nodes] | |||
| A master node in Elasticsearch continuously https://www.elastic.co/guide/en/elasticsearch/reference/current/cluster-fault-detection.html[monitors the cluster nodes] | |||
There was a problem hiding this comment.
Due to the nature of the Resiliency page & the fact that we only publish one version of it, this is a case where linking to current makes sense.
debadair
approved these changes
Apr 9, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 9, 2019
* [DOCS] Remove references to deprecated 'zen.discovery.minimum_master_nodes' setting
jrodewig
added a commit
that referenced
this pull request
Apr 9, 2019
* [DOCS] Remove references to deprecated 'zen.discovery.minimum_master_nodes' setting
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
* [DOCS] Remove references to deprecated 'zen.discovery.minimum_master_nodes' setting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two broken links in Elasticsearch Resiliency Status for v7.0 release.