Add enrich policy GET API #41384
Merged
Add enrich policy GET API #41384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit wires up the Rest calls and Transport calls for GET enrich policy, as well as tests and rest spec additions.
hub-cap
added
>enhancement
:Data Management/Ingest Node
|
Pinging @elastic/es-core-features |
martijnvg
reviewed
Apr 19, 2019
| if (policy == null) { | ||
| throw new ResourceNotFoundException("policy [{}] is missing", name); | ||
| } | ||
| return policy; |
There was a problem hiding this comment.
I think the two if statements in this method should be merged with EnrichStore#getPolicy(...) and also tests should move the EnrichStoreTests. Since the static method will basically by doing nothing, it can be merged with masterOperation(...)
|
|
||
| import static org.elasticsearch.xpack.enrich.EnrichPolicyTests.randomEnrichPolicy; | ||
|
|
||
| public class GetEnrichPolicyActionResponseTests extends AbstractWireSerializingTestCase<GetEnrichPolicyAction.Response> { |
There was a problem hiding this comment.
I think this test should extend AbstractSerializingTestCase, so that xcontent serialization is also tested.
|
I went ahead and removed this transport test as well, ala #41383 (comment), and fixed up the enrich store based on the review. |
|
@elasticmachine run elasticsearch-ci/1 |
|
@elasticmachine run elasticsearch-ci/1 |
jakelandis
approved these changes
Apr 26, 2019
|
@elasticmachine run elasticsearch-ci/1 |
hub-cap
added a commit
that referenced
this pull request
May 29, 2019
This commit wires up the Rest calls and Transport calls for GET enrich policy, as well as tests and rest spec additions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit wires up the Rest calls and Transport calls for GET enrich
policy, as well as tests and rest spec additions.