Skip to content

[DOCS] Remove delimited block for Asciidoctor migration #41582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2019
Merged

[DOCS] Remove delimited block for Asciidoctor migration #41582

merged 1 commit into from
Apr 26, 2019

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Apr 26, 2019 •
edited
Loading

In Asciidoctor, this delimited block resets the nested ordered list (changing d to a). This removes the block, which wasn't needed anyway.

Before/After Images in Asciidoctor

Before
asciidoctor-before

After
asciidoctor-after

@jrodewig jrodewig requested review from nik9000 and debadair April 26, 2019 13:45
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

@nik9000 nik9000 mentioned this pull request Apr 26, 2019
Merged
nik9000
nik9000 approved these changes Apr 26, 2019
View reviewed changes
Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so long as this still works in AsciiDoc too.

@jrodewig
Copy link
Contributor Author

Thanks @nik9000.

Here's how it outputs in AsciiDoc:
asciidoc-render

nik9000
nik9000 approved these changes Apr 26, 2019
View reviewed changes
Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@jrodewig jrodewig merged commit ce59d45 into elastic:master Apr 26, 2019
@jrodewig jrodewig deleted the asciidoctor-rolling-upgrades branch April 26, 2019 16:16
@jaymode jaymode added v7.0.1 and removed v7.0.2 labels Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nik9000 nik9000 nik9000 approved these changes

@debadair debadair Awaiting requested review from debadair

Assignees
No one assigned
Labels
>docs General docs changes v7.0.1 v7.2.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jrodewig @elasticmachine @nik9000 @jakelandis @jaymode