Skip to content

[DOCS] Fix delimited blocks for Asciidoctor migration #41583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2019
Merged

[DOCS] Fix delimited blocks for Asciidoctor migration #41583

merged 2 commits into from
Apr 26, 2019

Conversation

jrodewig
Copy link
Contributor

In Asciidoctor, these delimited block resets the nested ordered list (changing d to a and 6 to 1). This fixes those breaking changes.

Asciidoctor output before changes

asciidoctor-before

Asciidoctor output after changes

asciidoctor-after

AsciiDoc output after changes

asciidoc-output

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI blew up on it! Did you happen to commit half of the fix? Like just the opening of the delimited block but not the closing?

@jrodewig
Copy link
Contributor Author

Yep. That's exactly what happened. Fixed with 7ebb143.

Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now LGTM

@jrodewig jrodewig merged commit 4ab9e88 into elastic:master Apr 26, 2019
@jrodewig jrodewig deleted the asciidoctor-restart-upgrade branch April 26, 2019 15:41
@jaymode jaymode added v7.0.1 and removed v7.0.2 labels Apr 29, 2019
akhil10x5 pushed a commit to akhil10x5/elasticsearch that referenced this pull request May 2, 2019
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants