-
Notifications
You must be signed in to change notification settings - Fork 25.2k
[DOCS] Fix delimited blocks for Asciidoctor migration #41583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Fix delimited blocks for Asciidoctor migration #41583
Conversation
Pinging @elastic/es-docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI blew up on it! Did you happen to commit half of the fix? Like just the opening of the delimited block but not the closing?
Yep. That's exactly what happened. Fixed with 7ebb143. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now LGTM
In Asciidoctor, these delimited block resets the nested ordered list (changing
d
toa
and6
to1
). This fixes those breaking changes.Asciidoctor output before changes
Asciidoctor output after changes
AsciiDoc output after changes