Skip to content

[DOCS] Escape commas in deprecated[] for Asciidoctor migration #41598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2019
Merged

[DOCS] Escape commas in deprecated[] for Asciidoctor migration #41598

merged 1 commit into from
Apr 30, 2019

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Apr 26, 2019

Asciidoctor does not render text following the second comma in deprecated[] macros. This escapes the text in the deprecated[] macro in preparation for the Asciidoctor migration.

Quotes will be included in the existing AsciiDoc output, but I don't think that's too disruptive. It'll also be removed after the Asciidoctor migration is complete.

Relates to elastic/docs#827

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrodewig jrodewig merged commit 8e3ff67 into elastic:master Apr 30, 2019
@jrodewig jrodewig deleted the asciidoctor-mapping-boost branch April 30, 2019 19:50
akhil10x5 pushed a commit to akhil10x5/elasticsearch that referenced this pull request May 2, 2019
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants