[ML-DataFrame] reset/clear the position after indexer is done #41736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core |
hendrikmuhs
added
the
:StorageEngine/Rollup
|
Pinging @elastic/es-analytics-geo |
benwtrent
approved these changes
May 2, 2019
|
It seemed simple and I did not expected rollup to make trouble, but it did. For data frames after 1 run of the composite agg the stored position in the indexer should get reset. The position is immutable from the outside - which makes sense. This change sets the position when the indexer finishes. For rollup the position should be kept, for data frame it should be reset. Please let me know what you think, I am open for other options. |
polyfractal
approved these changes
May 3, 2019
hendrikmuhs
pushed a commit
that referenced
this pull request
May 6, 2019
reset/clear the position after indexer is done
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
…c#41736) reset/clear the position after indexer is done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reset/clear the position after indexer is done.