Ensure all JSON field types are available for lookup. #41914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if multiple `embedded_json` fields were added at once, only the last one would be registered with `FieldTypeLookup`. This bug was uncovered when trying out different scenarios for performance benchmarking.
jtibshirani
added
>bug
:Search Foundations/Mapping
|
Pinging @elastic/es-search |
|
@elasticmachine run elasticsearch-ci/1 |
jtibshirani
added a commit
that referenced
this pull request
Jun 14, 2019
Previously, if multiple `embedded_json` fields were added at once, only the last one would be registered with `FieldTypeLookup`. This bug was uncovered when trying out different scenarios for performance benchmarking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if multiple
embedded_jsonfields were added at once, only the lastone would be registered. This bug was uncovered when trying out different
scenarios for performance benchmarking.