-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Watcher: Allow to execute actions for each element in array #41997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
spinscale
merged 24 commits into
elastic:master
from
spinscale:1809-add-foreach-loop-in-action
Jul 3, 2019
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
54efef5
Watcher: Allow to execute actions for each element in array
spinscale 6f26c7b
Merge branch 'master' into 1809-add-foreach-loop-in-action
spinscale 11a96e1
Merge branch 'master' into 1809-add-foreach-loop-in-action
spinscale c3cb96d
fix test
spinscale d58818e
Merge branch 'master' into 1809-add-foreach-loop-in-action
spinscale 3d0ce81
fix path to use ctx by converting context to map
spinscale 8a2af63
Merge branch 'master' into 1809-add-foreach-loop-in-action
spinscale 7bc27f0
Merge branch 'master' into 1809-add-foreach-loop-in-action
spinscale 46901c8
WIP
spinscale 4e4ba21
Merge branch 'master' into 1809-add-foreach-loop-in-action
spinscale db479d7
fix test
spinscale 983e815
Merge branch 'master' into 1809-add-foreach-loop-in-action
spinscale d4d0490
fix docs
spinscale 1d9456c
Merge branch 'master' into 1809-add-foreach-loop-in-action
spinscale 66b284c
Merge branch 'master' into 1809-add-foreach-loop-in-action
spinscale 14dcc8d
review comments: limit runs to 100, doc updates
spinscale 2073d46
review comment: lift restriction on passing a map
spinscale 086fe24
Merge branch 'master' into 1809-add-foreach-loop-in-action
spinscale 95606e6
Merge branch 'master' into 1809-add-foreach-loop-in-action
spinscale 8029528
Fix tests
spinscale 9c0a0ba
update template
spinscale edc19a8
Merge branch 'master' into 1809-add-foreach-loop-in-action
spinscale b989cfb
remove tabs
spinscale c6d433e
Merge branch 'master' into 1809-add-foreach-loop-in-action
spinscale File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add an upper limit here ? I am fine with a hard coded
100
size (or something like that) just so that we don't allow this to be a DOS vector.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
set it hundred, also included the number of executed actions in the JSON that gets written to watch history
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
100 seems quite arbitrary from my perspective. Any chance to make this an option?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please open a new issue to make this configurable plus the rationale. The main goal here was to not let the watch run extremely long and block other watch executions, as well as its own executions.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filed as #45169