Skip to content

[DOCS] Rewrite fuzzy query docs #42078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Aug 14, 2019
Merged

[DOCS] Rewrite fuzzy query docs #42078

merged 13 commits into from
Aug 14, 2019

Conversation

jrodewig
Copy link
Contributor

Changes

  • Rewrites description of fuzzy query
  • Include all parameters in example request
  • Adds parameters sections

This is part of #40977, an effort to standardize documentation for query types.

Any and all feedback welcome!

Before

Before image Screen Shot 2019-05-08 at 11 34 54 AM

After

After image Screen Shot 2019-05-08 at 11 36 13 AM

@jrodewig jrodewig added >docs General docs changes :Search/Search Search-related issues that do not fall into other categories v8.0.0 v7.2.0 v7.0.2 v7.1.0 labels May 10, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

@jrodewig jrodewig mentioned this pull request May 10, 2019
Closed
62 tasks
@JessePelton
Copy link

"Removing a character: shouldn't "black -> back" be either "black -> back" or "black -> lack"? (The latter is easier to discern visually.)

@jrodewig
Copy link
Contributor Author

Thanks for the excellent catch @JessePelton! I've updated the example with 222eccd.

@jakelandis jakelandis removed the v7.1.0 label May 19, 2019
@jrodewig jrodewig added the v6.8.1 label Jun 6, 2019
@jrodewig jrodewig removed the v6.8.2 label Jun 28, 2019
@jrodewig
Copy link
Contributor Author

jrodewig commented Jul 3, 2019

@elasticmachine run elasticsearch-ci/docs-check

@jrodewig jrodewig added the v7.4.0 label Jul 3, 2019
@jpountz jpountz removed the v7.3.0 label Jul 3, 2019
mayya-sharipova
mayya-sharipova approved these changes Aug 14, 2019
View reviewed changes
Copy link
Contributor

@mayya-sharipova mayya-sharipova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrodewig Thanks for the PR. I have left some comments.

@jrodewig
Copy link
Contributor Author

@elasticmachine update branch

@jrodewig jrodewig merged commit 9c488f3 into elastic:master Aug 14, 2019
@jrodewig jrodewig deleted the fuzzy-query-rewrite branch August 14, 2019 17:06
jrodewig added a commit that referenced this pull request Aug 14, 2019
@jrodewig
[DOCS] Rewrite fuzzy query docs (#42078)
6904778
jrodewig added a commit that referenced this pull request Aug 14, 2019
@jrodewig
[DOCS] Rewrite fuzzy query docs (#42078)
52224e7
jrodewig added a commit that referenced this pull request Aug 14, 2019
@jrodewig
[DOCS] Rewrite fuzzy query docs (#42078)
91e8ccf
jrodewig added a commit that referenced this pull request Aug 14, 2019
@jrodewig
[DOCS] Rewrite fuzzy query docs (#42078)
57e2357
jrodewig added a commit that referenced this pull request Aug 14, 2019
@jrodewig
[DOCS] Rewrite fuzzy query docs (#42078)
9118b40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayya-sharipova mayya-sharipova mayya-sharipova approved these changes

Assignees
No one assigned
Labels
>docs General docs changes :Search/Search Search-related issues that do not fall into other categories v7.0.2 v7.1.2 v7.2.2 v7.3.1 v7.4.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jrodewig @elasticmachine @JessePelton @mayya-sharipova @jpountz @jakelandis