Skip to content

Remove TestXPackTransportClient #42103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2019

Conversation

rjernst
Copy link
Member

@rjernst rjernst commented May 12, 2019

In preparation for removing the transport client for 8.0, this commit
begins removing transport client testing infrastructure. The tests
removed here were all testing transport client specific behavior.
For the rest, there already exist http specific test methods.

In preparation for removing the transport client for 8.0, this commit
begins removing transport client testing infrastructure. The tests
removed here were all testing transport client specific behavior.
For the rest, there already exist http specific test methods.
@rjernst rjernst added :Core/Infra/Core Core issues without another label >refactoring v8.0.0 labels May 12, 2019
@rjernst rjernst requested a review from jaymode May 12, 2019 00:44
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

Copy link
Member

@jaymode jaymode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

import static org.hamcrest.CoreMatchers.is;
import static org.hamcrest.Matchers.containsString;

public class SslMultiPortTests extends SecurityIntegTestCase {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 👍

@rjernst rjernst merged commit 32553ef into elastic:master May 14, 2019
@rjernst rjernst deleted the remove_transport_client1 branch May 14, 2019 13:09
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
In preparation for removing the transport client for 8.0, this commit
begins removing transport client testing infrastructure. The tests
removed here were all testing transport client specific behavior.
For the rest, there already exist http specific test methods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Core Core issues without another label >refactoring v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants