Skip to content

Some Cleanup in o.e.gateway Package #42108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2019
Merged

Some Cleanup in o.e.gateway Package #42108

merged 1 commit into from
May 14, 2019

Conversation

original-brownbear
Copy link
Member

  • Removing obvious dead code
  • Removing redundant listener interface

@original-brownbear
Some Cleanup in o.e.gateway Package
e9ce7de 
* Removing obvious dead code
* Removing redundant listener interface
@original-brownbear original-brownbear added >non-issue :Distributed Indexing/Distributed A catch all label for anything in the Distributed Indexing Area. Please avoid if you can. v8.0.0 v7.2.0 labels May 12, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@original-brownbear
Copy link
Member Author

Jenkins run elasticsearch-ci/1

DaveCTurner
DaveCTurner approved these changes May 14, 2019
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaveCTurner
Copy link
Contributor

As a followup, I think AllocateDangledResponse can be easily Writeableified and it doesn't look like it needs that ack field at all.

@original-brownbear
Copy link
Member Author

thanks @DaveCTurner !

@original-brownbear original-brownbear merged commit 5cadfe7 into elastic:master May 14, 2019
@original-brownbear original-brownbear deleted the cleanup-gateway branch May 14, 2019 13:34
@original-brownbear original-brownbear mentioned this pull request May 15, 2019
Merged
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request May 27, 2019
@original-brownbear
Some Cleanup in o.e.gateway Package (elastic#42108)
31a8e0c 
* Removing obvious dead code
* Removing redundant listener interface
@original-brownbear original-brownbear mentioned this pull request May 27, 2019
Merged
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
@original-brownbear
Some Cleanup in o.e.gateway Package (elastic#42108)
e8a9075 
* Removing obvious dead code
* Removing redundant listener interface
original-brownbear added a commit that referenced this pull request May 27, 2019
@original-brownbear
Some Cleanup in o.e.gateway Package (#42108) (#42568)
49767fc 
* Removing obvious dead code
* Removing redundant listener interface
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaveCTurner DaveCTurner DaveCTurner approved these changes

@ywelsch ywelsch Awaiting requested review from ywelsch

Assignees
No one assigned
Labels
:Distributed Indexing/Distributed A catch all label for anything in the Distributed Indexing Area. Please avoid if you can. >non-issue v7.3.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@original-brownbear @elasticmachine @DaveCTurner @jakelandis