[DOCS] Set explicit anchor for "SysV init vs systemd" section
#42525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-docs |
|
I think the anchor change is better than duplicating the anchor. |
|
Thanks for your help @nik9000. This is now ready for your review. |
nik9000
requested changes
May 28, 2019
| @@ -128,6 +128,8 @@ sudo dpkg -i elasticsearch-{version}.deb | |||
|
|
|||
| endif::[] | |||
|
|
|||
| :int-context: deb | |||
There was a problem hiding this comment.
Could you do :init-context: instead?
There was a problem hiding this comment.
Added with c161040. Thanks!
jrodewig
added a commit
that referenced
this pull request
May 28, 2019
jrodewig
added a commit
that referenced
this pull request
May 28, 2019
jrodewig
added a commit
that referenced
this pull request
May 28, 2019
jrodewig
added a commit
that referenced
this pull request
May 28, 2019
jrodewig
added a commit
that referenced
this pull request
May 28, 2019
jrodewig
added a commit
that referenced
this pull request
May 28, 2019
jrodewig
added a commit
that referenced
this pull request
May 28, 2019
jrodewig
added a commit
that referenced
this pull request
May 28, 2019
jrodewig
added a commit
that referenced
this pull request
May 28, 2019
jrodewig
added a commit
that referenced
this pull request
May 28, 2019
jrodewig
added a commit
that referenced
this pull request
May 28, 2019
jrodewig
added a commit
that referenced
this pull request
May 28, 2019
jrodewig
added a commit
that referenced
this pull request
May 28, 2019
jrodewig
added a commit
that referenced
this pull request
May 28, 2019
jrodewig
added a commit
that referenced
this pull request
May 28, 2019
jrodewig
added a commit
that referenced
this pull request
May 28, 2019
jrodewig
added a commit
that referenced
this pull request
May 28, 2019
jrodewig
added a commit
that referenced
this pull request
May 28, 2019
jrodewig
added a commit
that referenced
this pull request
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix the following autogenerated anchors so they render consistently in AsciiDoc and Asciidoctor:
However, the
init-systemd.asciidocfile containing the anchor is included in two other files:This means the explicit anchors is reused. Reusing the anchor results in the following errors:
Next steps
@nik9000
Let me know if you have any suggestions. We might be better off just accepting the anchor change.