[DOCS] Update node descriptions for default distribution #42812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcawl
added
>docs
|
Pinging @elastic/es-distributed |
pmusa
reviewed
Jun 3, 2019
There was a problem hiding this comment.
I am not sure I am the right person to review this PR. From my understanding we were avoiding using the term x-pack, specially in the context of installing. The sentences are weird because x-pack is a gray area. You can use ML in basic (There is the data visualizer and import data though). Maybe calling out that the node.ml setting should not be used in the OSS version.
docs/reference/modules/node.asciidoc
Outdated
| @@ -131,8 +132,9 @@ cluster.remote.connect: false <4> | |||
| <4> Disable {ccs} (enabled by default). | |||
|
|
|||
| ifdef::include-xpack[] | |||
| NOTE: These settings apply only when {xpack} is not installed. To create a | |||
| dedicated data node when {xpack} is installed, see <<modules-node-xpack,{xpack} node settings>>. | |||
| NOTE: By default, when you install {es}, {xpack} is installed.These settings | |||
There was a problem hiding this comment.
it is missing a space after installed.
docs/reference/modules/node.asciidoc
Outdated
| @@ -159,8 +161,9 @@ cluster.remote.connect: false <4> | |||
| <4> Disable {ccs} (enabled by default). | |||
|
|
|||
| ifdef::include-xpack[] | |||
| NOTE: These settings apply only when {xpack} is not installed. To create a | |||
| dedicated ingest node when {xpack} is installed, see <<modules-node-xpack,{xpack} node settings>>. | |||
| NOTE: By default, when you install {es}, {xpack} is installed.These settings | |||
lcawl
added a commit
that referenced
this pull request
Jun 13, 2019
lcawl
added a commit
to lcawl/elasticsearch
that referenced
this pull request
Jun 13, 2019
lcawl
added a commit
that referenced
this pull request
Jun 13, 2019
lcawl
added a commit
that referenced
this pull request
Jun 13, 2019
lcawl
added a commit
that referenced
this pull request
Jun 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates https://www.elastic.co/guide/en/elasticsearch/reference/master/modules-node.html such that it's clearer that the initial examples don't apply to the default distribution.
It requires elastic/docs#917
It also cleans up some outstanding disparities in the dedicated node definitions related to #25210