Skip to content

Note behaviour of negative commit timeout in 6.x #42834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 22, 2019
Merged

Note behaviour of negative commit timeout in 6.x #42834

merged 2 commits into from
Jul 22, 2019

Conversation

harshbajaj16
Copy link

@harshbajaj16 harshbajaj16 commented Jun 4, 2019 •
edited by DaveCTurner
Loading

Fixes #36632

@cbuescher cbuescher added :Distributed Indexing/Distributed A catch all label for anything in the Distributed Indexing Area. Please avoid if you can. >docs General docs changes labels Jun 4, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@harshbajaj16 harshbajaj16 mentioned this pull request Jun 24, 2019
Closed
@DaveCTurner DaveCTurner self-requested a review June 24, 2019 07:12
@DaveCTurner DaveCTurner self-assigned this Jun 24, 2019
DaveCTurner
DaveCTurner requested changes Jul 4, 2019
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @harshbajaj16. I suggested a couple of minor changes.

@DaveCTurner
Copy link
Contributor

@harshbajaj16 just checking you received my comment above?

DaveCTurner
DaveCTurner approved these changes Jul 22, 2019
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaveCTurner
Copy link
Contributor

@elasticmachine test this please

@DaveCTurner DaveCTurner changed the title Document update for #36632 Note behaviour of negative commit timeout in 6.x Jul 22, 2019
@DaveCTurner DaveCTurner added v6.7.3 v6.8.3 :Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. and removed :Distributed Indexing/Distributed A catch all label for anything in the Distributed Indexing Area. Please avoid if you can. labels Jul 22, 2019
@DaveCTurner DaveCTurner merged commit 997fbde into elastic:6.7 Jul 22, 2019
DaveCTurner pushed a commit that referenced this pull request Jul 22, 2019
@harshbajaj16 @DaveCTurner
Note behaviour of negative commit timeout in 6.x (#42834)
0a1c93d 
Fixes #36632
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaveCTurner DaveCTurner DaveCTurner approved these changes

Assignees

@DaveCTurner DaveCTurner

Labels
:Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. >docs General docs changes v6.7.3 v6.8.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harshbajaj16 @elasticmachine @DaveCTurner @cbuescher