[FEATURE][ML] Ensure data extractor is not leaking scroll contexts #42960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core |
| return tryRequestWithSearchResponse(() -> executeSearchRequest(buildSearchRequest())); | ||
| } | ||
|
|
||
| private List<Row> tryRequestWithSearchResponse(Supplier<SearchResponse> request) throws IOException { |
There was a problem hiding this comment.
I think having this method is a nice way of handling with the 2 different requests in a single place. If people like it, we can reuse this in ScrollDataExtractor to simplify and rely on allow_partial_search_results to do its job of clearing the scroll context on error.
|
run elasticsearch-ci/bwc |
|
run elasticsearch-ci/default-distro |
dimitris-athanasiou
force-pushed
the
ensure-data-extractor-is-not-leaking-scroll-contexts
branch
from
75573d5 to
82bae15
Compare
benwtrent
approved these changes
Jun 11, 2019
dimitris-athanasiou
deleted the
ensure-data-extractor-is-not-leaking-scroll-contexts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds some basic unit tests for the DF data extractor