-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Advance checkpoints only after persisting ops #43205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marregui
added a commit
to crate/crate
that referenced
this pull request
Oct 31, 2019
marregui
added a commit
to crate/crate
that referenced
this pull request
Oct 31, 2019
marregui
added a commit
to crate/crate
that referenced
this pull request
Oct 31, 2019
marregui
added a commit
to crate/crate
that referenced
this pull request
Oct 31, 2019
Port of elastic/elasticsearch#43205 Local and global checkpoints currently do not correctly reflect what's persisted to disk. The issue is that the local checkpoint is adapted as soon as an operation is processed (but not fsynced yet). This leaves room for the history below the global checkpoint to still change in case of a crash. As we rely on global checkpoints for CCR as well as operation-based recoveries, this has the risk of shard copies / follower clusters going out of sync.
marregui
added a commit
to crate/crate
that referenced
this pull request
Nov 4, 2019
Port of elastic/elasticsearch#43205 Local and global checkpoints currently do not correctly reflect what's persisted to disk. The issue is that the local checkpoint is adapted as soon as an operation is processed (but not fsynced yet). This leaves room for the history below the global checkpoint to still change in case of a crash. As we rely on global checkpoints for CCR as well as operation-based recoveries, this has the risk of shard copies / follower clusters going out of sync.
marregui
added a commit
to crate/crate
that referenced
this pull request
Nov 4, 2019
Port of elastic/elasticsearch#43205 Local and global checkpoints currently do not correctly reflect what's persisted to disk. The issue is that the local checkpoint is adapted as soon as an operation is processed (but not fsynced yet). This leaves room for the history below the global checkpoint to still change in case of a crash. As we rely on global checkpoints for CCR as well as operation-based recoveries, this has the risk of shard copies / follower clusters going out of sync.
marregui
added a commit
to crate/crate
that referenced
this pull request
Nov 7, 2019
Port of elastic/elasticsearch#43205 Local and global checkpoints currently do not correctly reflect what's persisted to disk. The issue is that the local checkpoint is adapted as soon as an operation is processed (but not fsynced yet). This leaves room for the history below the global checkpoint to still change in case of a crash. As we rely on global checkpoints for CCR as well as operation-based recoveries, this has the risk of shard copies / follower clusters going out of sync.
marregui
added a commit
to crate/crate
that referenced
this pull request
Nov 11, 2019
Port of elastic/elasticsearch#43205 Local and global checkpoints currently do not correctly reflect what's persisted to disk. The issue is that the local checkpoint is adapted as soon as an operation is processed (but not fsynced yet). This leaves room for the history below the global checkpoint to still change in case of a crash. As we rely on global checkpoints for CCR as well as operation-based recoveries, this has the risk of shard copies / follower clusters going out of sync.
mergify bot
pushed a commit
to crate/crate
that referenced
this pull request
Nov 11, 2019
Port of elastic/elasticsearch#43205 Local and global checkpoints currently do not correctly reflect what's persisted to disk. The issue is that the local checkpoint is adapted as soon as an operation is processed (but not fsynced yet). This leaves room for the history below the global checkpoint to still change in case of a crash. As we rely on global checkpoints for CCR as well as operation-based recoveries, this has the risk of shard copies / follower clusters going out of sync.
mergify bot
pushed a commit
to crate/crate
that referenced
this pull request
Dec 5, 2019
Port of elastic/elasticsearch#43205 Local and global checkpoints currently do not correctly reflect what's persisted to disk. The issue is that the local checkpoint is adapted as soon as an operation is processed (but not fsynced yet). This leaves room for the history below the global checkpoint to still change in case of a crash. As we rely on global checkpoints for CCR as well as operation-based recoveries, this has the risk of shard copies / follower clusters going out of sync. (cherry picked from commit dfed1ca) # Conflicts: # es/es-server/src/main/java/org/elasticsearch/index/engine/InternalEngine.java # es/es-server/src/main/java/org/elasticsearch/index/seqno/LocalCheckpointTracker.java # es/es-server/src/main/java/org/elasticsearch/indices/recovery/RecoverySourceHandler.java # es/es-server/src/test/java/org/elasticsearch/action/support/replication/ReplicationOperationTests.java # es/es-server/src/test/java/org/elasticsearch/index/engine/InternalEngineTests.java # es/es-testing/src/main/java/org/elasticsearch/index/shard/IndexShardTestCase.java
marregui
added a commit
to crate/crate
that referenced
this pull request
Dec 5, 2019
Local and global checkpoints currently do not correctly reflect what's persisted to disk. The issue is that the local checkpoint is adapted as soon as an operation is processed (but not fsynced yet). This leaves room for the history below the global checkpoint to still change in case of a crash. As we rely on global checkpoints for CCR as well as operation-based recoveries, this has the risk of shard copies / follower clusters going out of sync. Port of elastic/elasticsearch#43205 (cherry picked from commit dfed1ca)
mergify bot
pushed a commit
to crate/crate
that referenced
this pull request
Dec 5, 2019
Local and global checkpoints currently do not correctly reflect what's persisted to disk. The issue is that the local checkpoint is adapted as soon as an operation is processed (but not fsynced yet). This leaves room for the history below the global checkpoint to still change in case of a crash. As we rely on global checkpoints for CCR as well as operation-based recoveries, this has the risk of shard copies / follower clusters going out of sync. Port of elastic/elasticsearch#43205 (cherry picked from commit dfed1ca)
kovrus
added a commit
to crate/crate
that referenced
this pull request
Sep 25, 2020
…VerifyShardBeforeCloseAction #9309 ports over elastic/elasticsearch#43205 but at that point TransportVerifyShardBeforeCloseAction was not present in our code base.
kovrus
added a commit
to crate/crate
that referenced
this pull request
Sep 25, 2020
…ifyShardBeforeCloseAction #9309 ports over elastic/elasticsearch#43205 but at that point TransportVerifyShardBeforeCloseAction was not present in our code base.
kovrus
added a commit
to crate/crate
that referenced
this pull request
Sep 25, 2020
…ifyShardBeforeCloseAction #9309 ports over elastic/elasticsearch#43205 but at that point TransportVerifyShardBeforeCloseAction was not present in our code base.
kovrus
added a commit
to crate/crate
that referenced
this pull request
Sep 26, 2020
…ifyShardBeforeCloseAction #9309 ports over elastic/elasticsearch#43205 but at that point TransportVerifyShardBeforeCloseAction was not present in our code base.
kovrus
added a commit
to crate/crate
that referenced
this pull request
Sep 28, 2020
…ifyShardBeforeCloseAction #9309 ports over elastic/elasticsearch#43205 but at that point TransportVerifyShardBeforeCloseAction was not present in our code base.
mergify bot
pushed a commit
to crate/crate
that referenced
this pull request
Sep 28, 2020
…ifyShardBeforeCloseAction #9309 ports over elastic/elasticsearch#43205 but at that point TransportVerifyShardBeforeCloseAction was not present in our code base.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>bug
:Distributed Indexing/Distributed
A catch all label for anything in the Distributed Indexing Area. Please avoid if you can.
resiliency
v7.3.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local and global checkpoints currently do not correctly reflect what's persisted to disk. The issue is that the local checkpoint is adapted as soon as an operation is processed (but not fsynced yet). This leaves room for the history below the global checkpoint to still change in case of a crash. As we rely on global checkpoints for CCR as well as operation-based recoveries, this has the risk of shard copies / follower clusters going out of sync.
This PR required changing some core classes in the system: