Pull the flattened field type into a mapper plugin. #43250
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shows a prototype approach to pulling
FlatObjectFieldMapper
into itsown
MapperPlugin
. It introduces two new methods onFieldMapper
:supportsKeyedFieldLookup()
, which specifies whether the field type supportslooking for subfields
keyedFieldType(String key)
, which gives the opportunity to return a specialfield type for a subfield
FieldTypeLookup
has been updated to refer to 'keyed lookup' instead of'flattened objects'. I pulled most tests into a new
flattened
module(although some still need to be migrated).