-
Notifications
You must be signed in to change notification settings - Fork 25.2k
[DOCS] Rewrite range
query
#43282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Rewrite range
query
#43282
Conversation
Pinging @elastic/es-docs |
Pinging @elastic/es-search |
https://en.wikipedia.org/wiki/List_of_UTC_time_offsets[Coordinated Universal Time | ||
(UTC) offset] used to convert `date` values in the query to UTC. Optional. | ||
|
||
Valid values are ISO 8601 UTC offsets, such as `+01:00` or -`08:00`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think ISO 8601 does not include all the time zone ids that are possible here, especially not the ones with time zone changes on e.g. summer time (like "Europe/Berlin", "America/Toronto" etc...). Since its not obvious that those are allowed here, I think we should mention at least one of them. I don't know if there is a comprehensive list of all the IANA time zone ids that Java allows, but maybe https://en.wikipedia.org/wiki/List_of_tz_database_time_zones is a good enough link? Will check if those are mostly accurate in terms of what Javas time library allows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just did some random checks between what ZoneId.getAvailableZoneIds()
(should be what the java time library accepts) reports and whats on the liked wikipedia list, seems quite accurate to me atm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review @cbuescher. I documented support for IANA time zone IDs with d508e2d.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I left a small comment regarding the supported range of time zone ids. Maybe that part could be extended a little bit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for including the IANA ids.
Changes
range
queryThis is part of #40977, an effort to standardize documentation for query types.
Before
Before image
After
After image