-
Notifications
You must be signed in to change notification settings - Fork 25.2k
7.2.0 release notes #43343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7.2.0 release notes #43343
Conversation
Pinging @elastic/es-docs |
@elasticmachine run elasticsearch-ci/docbldesx |
Hmm... issues talking with Github:
trying again. |
These issues are not limited to your PR. I was able to build the Elasticsearch Reference and the Installation and Upgrade Guide (which re-uses the breaking changes) successfully. |
@droberts195 I incorporated the ml-cpp PRs from https://github.com/elastic/ml-cpp/blob/7.2/docs/CHANGELOG.asciidoc here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and builds successfully
@@ -220,6 +220,14 @@ Machine Learning:: | |||
* Add task recovery on node change {pull}39416[#39416] | |||
* Stop tasks on failure {pull}39203[#39203] | |||
* Add _preview endpoint {pull}38924[#38924] | |||
* Remove hard limit for maximum forecast interval and limit based on the time interval of data added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change had both a Java and a C++ component. The Java change is release noted as "Increase maximum forecast interval to 10 years" 8 lines above.
What do you think about combining them @lcawl. Maybe delete the two current items and replace with something like:
- Increase maximum forecast interval from 8 weeks to a limit based on the amount of data seen, up to a maximum of 10 years {ml-pull}214[multicast fails with network interfaces instead of IP #214] and {pull}41082[Increase maximum forecast interval to 10 years. #41082] (issue: {issue}41103[[ML] Extend ML Forecast beyond 8 weeks in the REST API #41103])
But I'll leave the exact wording up to you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @droberts195 I committed that change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (after addressing others comments)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@giladgal @lcawl - Could I request an additional review for the release highlights ? https://github.com/elastic/elasticsearch/pull/43343/files#diff-3e5d6e4c920b36c3bf921860e6c2b57d ? |
This sentence is quite long and a bit unclear:
Perhaps it could be changed to something like this?:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few nits but nothing blocking aside from @lcawl's changes.
Co-Authored-By: Lisa Cawley <[email protected]>
Co-Authored-By: Lisa Cawley <[email protected]>
Co-Authored-By: Lisa Cawley <[email protected]>
Co-Authored-By: James Rodewig <[email protected]>
Co-Authored-By: James Rodewig <[email protected]>
Co-Authored-By: James Rodewig <[email protected]>
Co-Authored-By: James Rodewig <[email protected]>
@tlrx @ywelsch - any suggestions for Lisa's comment ? #43343 (comment) ? |
For example, you can use this query to give higher scores to documents with dates | ||
closer to a certain date or locations closer to a certain location. | ||
closer to a certain date, or to documents with locations closer to a certain location. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other things I would consider including:
Replicated closed indices
Snapshot repositories app
SQL Median Absolute Deviation
SQL CASE/WHEN/END
HTML Strip Processor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replicated closed indices (already covered)
Snapshot repository app - since this is a Kibana and these are ES release notes probably best for blog
SQL * and Html Strip Processor - possibly... these are great features, but trying to keep the list relatively small. We have the full release notes which covers these, and IMO the blogs can go into quite a bit more detail.
Lisa made a good suggestion, we should change this to what was suggested. Do you prefer me to dot it or can you do it yourself as part of this PR? |
@elasticmachine run elasticsearch-ci/docs-check |
highlights are still a todo..
Due to the timing and state of branches at time of the label creation the initial attempt to create these resulted in many false positives. To get a more correct list I added all of the released 7.x versions to be ignored in the script that generates these.
After I had the more refined list, I cleaned up the
[
category]
in the commit message and other other minor spelling and grammar issues.Finally, I manually moved some items between categories. For example, I moved some new features down to enhancements and vice-versa. This step is mostly subjective and would appreciate a second opinion that the categories are are correct. (I didn't move any of the bugs around).
Highlights will be added on this PR or different PR's as I coordinate them independently.