Skip to content

7.2.0 release notes #43343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jun 25, 2019
Merged

7.2.0 release notes #43343

merged 16 commits into from
Jun 25, 2019

Conversation

jakelandis
Copy link
Contributor

highlights are still a todo..

Due to the timing and state of branches at time of the label creation the initial attempt to create these resulted in many false positives. To get a more correct list I added all of the released 7.x versions to be ignored in the script that generates these.

my %Ignore = map { $_ => 1 }
    ( ">non-issue", ">refactoring", ">docs", ">test", ">test-failure", ">test-mute", ":Core/Infra/Build", "backport",  "v7.0.0", "v7.0.0-beta1", "v7.0.0-rc1", "v7.0.0-rc2", "v7.1.0", "v7.1.1",  "v7.0.1" );

After I had the more refined list, I cleaned up the [category] in the commit message and other other minor spelling and grammar issues.

Finally, I manually moved some items between categories. For example, I moved some new features down to enhancements and vice-versa. This step is mostly subjective and would appreciate a second opinion that the categories are are correct. (I didn't move any of the bugs around).

Highlights will be added on this PR or different PR's as I coordinate them independently.

@jakelandis jakelandis added >docs General docs changes v7.2.0 labels Jun 18, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

@jakelandis
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/docbldesx

@jakelandis
Copy link
Contributor Author

Hmm... issues talking with Github:

13:09:49 Cloning into 'docs'...
13:11:57 fatal: unable to access 'https://github.com/elastic/docs/': Failed connect to github.com:443; Connection timed out

trying again.
@elasticmachine run elasticsearch-ci/docbldesx

@lcawl
Copy link
Contributor

lcawl commented Jun 18, 2019

Hmm... issues talking with Github:

These issues are not limited to your PR. I was able to build the Elasticsearch Reference and the Installation and Upgrade Guide (which re-uses the breaking changes) successfully.

@lcawl
Copy link
Contributor

lcawl commented Jun 18, 2019

Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and builds successfully

@@ -220,6 +220,14 @@ Machine Learning::
* Add task recovery on node change {pull}39416[#39416]
* Stop tasks on failure {pull}39203[#39203]
* Add _preview endpoint {pull}38924[#38924]
* Remove hard limit for maximum forecast interval and limit based on the time interval of data added
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change had both a Java and a C++ component. The Java change is release noted as "Increase maximum forecast interval to 10 years" 8 lines above.

What do you think about combining them @lcawl. Maybe delete the two current items and replace with something like:

But I'll leave the exact wording up to you.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @droberts195 I committed that change.

Copy link
Contributor

@colings86 colings86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (after addressing others comments)

Copy link
Contributor

@giladgal giladgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakelandis
Copy link
Contributor Author

@giladgal @lcawl - Could I request an additional review for the release highlights ? https://github.com/elastic/elasticsearch/pull/43343/files#diff-3e5d6e4c920b36c3bf921860e6c2b57d ?

@lcawl
Copy link
Contributor

lcawl commented Jun 24, 2019

This sentence is quite long and a bit unclear:

As soon as an index is closed, Elasticsearch takes care of safely tearing down the "opened" shards before reinitializing them as "closed" shards, which require much less resources while still providing the ability for shards to be promoted as primaries or to be recovered from peer.

Perhaps it could be changed to something like this?:

As soon as an index is closed,
Elasticsearch takes care of safely tearing down the "opened" shards before
reinitializing them as "closed" shards, which require fewer resources. Closed shards can later be promoted to primary shards (link to how/when this happens?) or automatically recovered during {ref}/recovery.html[peer recovery].

Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few nits but nothing blocking aside from @lcawl's changes.

@jakelandis
Copy link
Contributor Author

@tlrx @ywelsch - any suggestions for Lisa's comment ? #43343 (comment) ?

For example, you can use this query to give higher scores to documents with dates
closer to a certain date or locations closer to a certain location.
closer to a certain date, or to documents with locations closer to a certain location.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other things I would consider including:
Replicated closed indices
Snapshot repositories app
SQL Median Absolute Deviation
SQL CASE/WHEN/END
HTML Strip Processor

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replicated closed indices (already covered)
Snapshot repository app - since this is a Kibana and these are ES release notes probably best for blog

SQL * and Html Strip Processor - possibly... these are great features, but trying to keep the list relatively small. We have the full release notes which covers these, and IMO the blogs can go into quite a bit more detail.

@tlrx
Copy link
Member

tlrx commented Jun 25, 2019

@tlrx @ywelsch - any suggestions for Lisa's comment ? #43343 (comment) ?

Lisa made a good suggestion, we should change this to what was suggested. Do you prefer me to dot it or can you do it yourself as part of this PR?

@DaveCTurner DaveCTurner dismissed their stale review June 25, 2019 07:46

Requested change made

@jakelandis
Copy link
Contributor Author

thanks @tlrx and @lcawl - I have made the changes requested. However, I couldn't find relevant documentation to link.

@jakelandis
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/docs-check

@bmorelli25 bmorelli25 merged commit 4400448 into elastic:7.2 Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes v7.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants