Do not allow version in Rest Update API

[PnPie]

The versioning of Update API doesn't rely on version number anymore (and rather on sequence number). But in rest api level we ignored the "version" and "version_type" parameter, so that the server cannot raise the exception when whey were set.

This PR restores "version" and "version_type" parsing in Update Rest API so that we can get the appropriate errors.

Relates to #42497

[elasticmachine]

Pinging @elastic/es-distributed

[dnhatn]

Thank you for working on this PR. I think we should not call UpdateRequest#version() and UpdateRequest#versionType() when parsing an update request because these methods always throw an exception. This would make every update request fail (you can run ./gradlew :distribution:archives:integ-test-zip:check). We can instead throw an exception only if either version or version_type parameter is provided. We might also need to make the behavior of update and delete consistent in a follow-up.

[PnPie]

Hi @dnhatn I see the problem and I updated it to parse version/version_type if provided.

[dnhatn]

@PnPie I am sorry for being slow on this. I left a comment on the validation. Can you also add a YAML test ensuring that we return bad_request for an update request if version or version_type is provided? Thank you!

[PnPie]

Hi @dnhatn sorry for being slow on this too. I added a YAML test for this but it throws an exception directly at the YAML test level, before going into rest request parsing part. I see it's because in YAML test update api spec we have removed version/version_type from supported Params. So that means we cannot test this Exception at YAML test layer ?

[dnhatn]

@elasticmachine test this please

[dnhatn]

I left an optional comment but LGTM. Thanks @PnPie for working on this :).

[dnhatn]

@elasticmachine update branch

[dnhatn]

@elasticmachine test this please

[dnhatn]

@PnPie Thanks again for working on this.