Move nio channel initialization to event loop #43780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tim-Brooks
added
>non-issue
WIP
:Distributed Coordination/Network
|
Pinging @elastic/es-distributed |
|
#44355 can be reverted once this is merged |
ywelsch
approved these changes
Jul 30, 2019
There was a problem hiding this comment.
Looks good to me. Can you have a look too @original-brownbear?
| socket.setReceiveBufferSize(tcpReceiveBufferSize); | ||
| } | ||
| socketOptionsSet = true; | ||
| } catch (IOException e) { |
There was a problem hiding this comment.
can you add trace logging here so that we debug possible problems with socket options being set later?
There was a problem hiding this comment.
I don't think we can do that because we have no logging infra in the nio module.
| @@ -118,11 +118,11 @@ public void closeChannel() { | |||
| public NioSelector getSelector() { | |||
| throw new UnsupportedOperationException("not implemented"); | |||
| } | |||
|
|
|||
jkakavas
pushed a commit
that referenced
this pull request
Jul 31, 2019
Currently in the transport-nio work we connect and bind channels on the a thread before the channel is registered with a selector. Additionally, it is at this point that we set all the socket options. This commit moves these operations onto the event-loop after the channel has been registered with a selector. It attempts to set the socket options for a non-server channel at registration time. If that fails, it will attempt to set the options after the channel is connected. This should fix #41071.
Tim-Brooks
added a commit
to Tim-Brooks/elasticsearch
that referenced
this pull request
Aug 2, 2019
Currently in the transport-nio work we connect and bind channels on the a thread before the channel is registered with a selector. Additionally, it is at this point that we set all the socket options. This commit moves these operations onto the event-loop after the channel has been registered with a selector. It attempts to set the socket options for a non-server channel at registration time. If that fails, it will attempt to set the options after the channel is connected. This should fix elastic#41071.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in the transport-nio work we connect and bind channels on the
a thread before the channel is registered with a selector. Additionally,
it is at this point that we set all the socket options. This commit
moves these operations onto the event-loop after the channel has been
registered with a selector. It attempts to set the socket options for a
non-server channel at registration time. If that fails, it will attempt
to set the options after the channel is connected. This should fix
#41071.