-
Notifications
You must be signed in to change notification settings - Fork 25.2k
[DOCS] Make Query DSL titles consistent #43935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Make Query DSL titles consistent #43935
Conversation
Pinging @elastic/es-docs |
Pinging @elastic/es-search |
What about sorting alphabetically all these items ? |
Thanks for the feedback @EmmanuelDemey. I've alphabetized the queries and some other nav items with bec3b2d. I left some items, like context conceptual information and shared parameters, in the existing order. |
@@ -1,5 +1,8 @@ | |||
[[query-dsl-match-query]] | |||
=== Match Query |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the "Query" be "query" here too?
=== Match Query
Should the capitalization also be changed in query-dsl-minimum-should-match.html and query-dsl-multi-term-rewrite.html ? Those are two pages in the Query DSL section that stand out now as having the old style of capitalization. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added two comments, but otherwise LGTM and builds successfully
Thanks for looking @lcawl. I fixed the missed match query and parameters with ecaa1ce. |
Ignoring elasticsearch-ci/docbldesx as elasticsearch-ci/docs replaced that check. |
Changes
Screenshots
Query DSL nav
Example query title