Only apply initial recovery filter to shrunk shard #44054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today the `index.routing.allocation.initial_recovery._id` setting can only be set on indices that are the result of a shrink, but the filtered allocation decider also applies this filter to shards with a recovery source of `EMPTY_STORE`. The only way to have this setting set while the recovery source is `EMPTY_STORE` is to force-allocate an empty primary, but such a forced allocation ignores this allocation decider. This commit simplifies the allocation decider so that the `initial_recovery` setting only applies to shards with a recovery source of `LOCAL_SHARDS`.
DaveCTurner
added
>non-issue
:Distributed Coordination/Allocation
|
Pinging @elastic/es-distributed |
DaveCTurner
deleted the
2019-07-08-initial-recovery-filters-shrunk-shards-only
branch
DaveCTurner
added a commit
that referenced
this pull request
Jul 9, 2019
Today the `index.routing.allocation.initial_recovery._id` setting can only be set on indices that are the result of a shrink, but the filtered allocation decider also applies this filter to shards with a recovery source of `EMPTY_STORE`. The only way to have this setting set while the recovery source is `EMPTY_STORE` is to force-allocate an empty primary, but such a forced allocation ignores this allocation decider. This commit simplifies the allocation decider so that the `initial_recovery` setting only applies to shards with a recovery source of `LOCAL_SHARDS`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today the
index.routing.allocation.initial_recovery._idsetting can only beset on indices that are the result of a shrink, but the filtered allocation
decider also applies this filter to shards with a recovery source of
EMPTY_STORE. The only way to have this setting set while the recovery sourceis
EMPTY_STOREis to force-allocate an empty primary, but such a forcedallocation ignores this allocation decider.
This commit simplifies the allocation decider so that the
initial_recoverysetting only applies to shards with a recovery source of
LOCAL_SHARDS.