Add DatafeedTimingStats.average_search_time_per_bucket_ms and TimingStats.total_bucket_processing_time_ms stats #44125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core |
przemekwitek
force-pushed
the
datafeed-more-timing-stats
branch
4 times, most recently
from
96e4f2a to
7335f8f
Compare
przemekwitek
changed the title
przemekwitek
changed the title
przemekwitek
changed the title
przemekwitek
force-pushed
the
datafeed-more-timing-stats
branch
2 times, most recently
from
581dc3b to
9ffd0dc
Compare
|
run elasticsearch-ci/packaging-sample |
|
run elasticsearch-ci/packaging-sample |
1 similar comment
|
run elasticsearch-ci/packaging-sample |
benwtrent
reviewed
Jul 12, 2019
| jobId, | ||
| getOrDefault(bucketCount, 0L), | ||
| getOrDefault(totalBucketProcessingTimeMs, 0.0), | ||
| minBucketProcessingTimeMs, |
There was a problem hiding this comment.
I am not sure why we are NOT allowing bucketCount and totalBucketProcessingTimeMs to be null but we ARE allowing all the other stats to be null. It seems to be that we should do logical zero values across the board.
There was a problem hiding this comment.
My thinking was that we should provide non-null values wherever possible to simplify dealing with the resulting stats.
We can do it for bucketCount and totalBucketProcessingTimeMs because "0" is natural default value for them.
However, Min, Max and AVG need at least one data point to be calculated so there is no natural default value here.
WDYT?
...ore/src/main/java/org/elasticsearch/xpack/core/ml/job/persistence/ElasticsearchMappings.java
Outdated
Show resolved
Hide resolved
.../plugin/core/src/main/java/org/elasticsearch/xpack/core/ml/datafeed/DatafeedTimingStats.java
Outdated
Show resolved
Hide resolved
...lugin/core/src/main/java/org/elasticsearch/xpack/core/ml/action/GetDatafeedsStatsAction.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ml/action/GetJobsStatsAction.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/elasticsearch/xpack/core/ml/job/process/autodetect/state/TimingStats.java
Outdated
Show resolved
Hide resolved
benwtrent
approved these changes
Jul 15, 2019
przemekwitek
force-pushed
the
datafeed-more-timing-stats
branch
from
f6fedac to
1355f4f
Compare
przemekwitek
added a commit
to przemekwitek/elasticsearch
that referenced
this pull request
Jul 16, 2019
…tats.total_bucket_processing_time_ms stats (elastic#44125)
56 tasks
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Oct 21, 2019
…e_ms to ml stats Relates: elastic/elasticsearch#44125 This commit adds DatafeedTimingStats to DatafeedStats, and ExponentialAverageBucketProcessingTimePerHourMilliseconds to JobStats.
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Oct 21, 2019
…e_ms to ml stats (#4163) Relates: elastic/elasticsearch#44125 This commit adds DatafeedTimingStats to DatafeedStats, and ExponentialAverageBucketProcessingTimePerHourMilliseconds to JobStats.
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Oct 21, 2019
…e_ms to ml stats (#4163) Relates: elastic/elasticsearch#44125 This commit adds DatafeedTimingStats to DatafeedStats, and ExponentialAverageBucketProcessingTimePerHourMilliseconds to JobStats. (cherry picked from commit 83bf3e3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds three new fields:
Fields {average_search_time_per_bucket_ms, total_bucket_processing_time_ms} are calculated from other fields and not persisted in the job results index
Related to #29857