Relax Failure Type Assertion in TransportWriteAction #44137
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Other IOException during the replica write are simulated in the test (`SearchWithRandomExceptionsIT`) and seem possible but will trip the assertion here -> removed it * Closes elastic#40435
original-brownbear
added
>test
|
Pinging @elastic/es-distributed |
|
Closing this after talking to Nhat I understand this better now, still the assertion here and the fact that the IO exception is passed as a result is what's breaking the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(
SearchWithRandomExceptionsIT) and seem possible but will trip the assertion here -> removed it@ywelsch can you take a look here? It is not clear to me why we need that type assertion since we could theoretically run into all kinds of
IOExceptions during the replica action?