Make testDatafeedTimingStats_DatafeedJobIdUpdated test easier to debug #44206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
przemekwitek
added
>test-failure
|
Pinging @elastic/ml-core |
|
run elasticsearch-ci/packaging-sample |
|
run elasticsearch-ci/bwc |
davidkyle
approved these changes
Jul 11, 2019
There was a problem hiding this comment.
LGTM
"Closes #44196" is an optimistic statement, I'm not sure what the root cause it but the loop unrolling and unique names will help debugging and finding the failure in the log file. State is cleared between tests and jobs deleted so name clashes won't be problem (it is an error to create a job with the same name anyway).
...ve-multi-node-tests/src/test/java/org/elasticsearch/xpack/ml/integration/DatafeedJobsIT.java
Outdated
Show resolved
Hide resolved
przemekwitek
commented
Jul 11, 2019
...ve-multi-node-tests/src/test/java/org/elasticsearch/xpack/ml/integration/DatafeedJobsIT.java
Outdated
Show resolved
Hide resolved
|
run elasticsearch-ci/bwc |
…d tests so that they do not clash with names from other tests * Unroll the loops so that it is easier to track down which iteration failed should the exception occur
przemekwitek
force-pushed
the
fix-timing-stats-java-test
branch
from
8a9e4a9 to
d59543c
Compare
przemekwitek
changed the title
przemekwitek
added a commit
to przemekwitek/elasticsearch
that referenced
this pull request
Jul 12, 2019
przemekwitek
added a commit
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #44196