[ML][Data Frame] responding with 409 status code when failing _stop #44231
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License; | ||
| * you may not use this file except in compliance with the Elastic License. | ||
| */ | ||
| package org.elasticsearch.xpack.dataframe.action; | ||
|
|
||
| import org.elasticsearch.ElasticsearchStatusException; | ||
| import org.elasticsearch.Version; | ||
| import org.elasticsearch.cluster.ClusterName; | ||
| import org.elasticsearch.cluster.ClusterState; | ||
| import org.elasticsearch.cluster.metadata.MetaData; | ||
| import org.elasticsearch.persistent.PersistentTasksCustomMetaData; | ||
| import org.elasticsearch.test.ESTestCase; | ||
| import org.elasticsearch.xpack.core.dataframe.DataFrameMessages; | ||
| import org.elasticsearch.xpack.core.dataframe.transforms.DataFrameTransform; | ||
| import org.elasticsearch.xpack.core.dataframe.transforms.DataFrameTransformState; | ||
| import org.elasticsearch.xpack.core.dataframe.transforms.DataFrameTransformTaskState; | ||
| import org.elasticsearch.xpack.core.indexing.IndexerState; | ||
|
|
||
| import java.util.Arrays; | ||
| import java.util.Collections; | ||
|
|
||
| import static org.elasticsearch.rest.RestStatus.CONFLICT; | ||
| import static org.hamcrest.Matchers.equalTo; | ||
|
|
||
| public class TransportStopDataFrameTransformActionTests extends ESTestCase { | ||
|
|
||
| private MetaData.Builder buildMetadata(PersistentTasksCustomMetaData ptasks) { | ||
| return MetaData.builder().putCustom(PersistentTasksCustomMetaData.TYPE, ptasks); | ||
| } | ||
|
|
||
| public void testTaskStateValidationWithNoTasks() { | ||
| MetaData.Builder metaData = MetaData.builder(); | ||
| ClusterState.Builder csBuilder = ClusterState.builder(new ClusterName("_name")).metaData(metaData); | ||
| TransportStopDataFrameTransformAction.validateTaskState(csBuilder.build(), Collections.singletonList("non-failed-task"), false); | ||
|
|
||
| PersistentTasksCustomMetaData.Builder pTasksBuilder = PersistentTasksCustomMetaData.builder(); | ||
| csBuilder = ClusterState.builder(new ClusterName("_name")).metaData(buildMetadata(pTasksBuilder.build())); | ||
| TransportStopDataFrameTransformAction.validateTaskState(csBuilder.build(), Collections.singletonList("non-failed-task"), false); | ||
| } | ||
|
|
||
| public void testTaskStateValidationWithDataFrameTasks() { | ||
| // Test with the task state being null | ||
| PersistentTasksCustomMetaData.Builder pTasksBuilder = PersistentTasksCustomMetaData.builder() | ||
| .addTask("non-failed-task", | ||
| DataFrameTransform.NAME, | ||
| new DataFrameTransform("data-frame-task-1", Version.CURRENT, null), | ||
| new PersistentTasksCustomMetaData.Assignment("current-data-node-with-1-tasks", "")); | ||
| ClusterState.Builder csBuilder = ClusterState.builder(new ClusterName("_name")).metaData(buildMetadata(pTasksBuilder.build())); | ||
|
|
||
| TransportStopDataFrameTransformAction.validateTaskState(csBuilder.build(), Collections.singletonList("non-failed-task"), false); | ||
|
|
||
| // test again with a non failed task but this time it has internal state | ||
| pTasksBuilder.updateTaskState("non-failed-task", new DataFrameTransformState(DataFrameTransformTaskState.STOPPED, | ||
| IndexerState.STOPPED, | ||
| null, | ||
| 0L, | ||
| null, | ||
| null)); | ||
| csBuilder = ClusterState.builder(new ClusterName("_name")).metaData(buildMetadata(pTasksBuilder.build())); | ||
|
|
||
| TransportStopDataFrameTransformAction.validateTaskState(csBuilder.build(), Collections.singletonList("non-failed-task"), false); | ||
|
|
||
| pTasksBuilder.addTask("failed-task", | ||
| DataFrameTransform.NAME, | ||
| new DataFrameTransform("data-frame-task-1", Version.CURRENT, null), | ||
| new PersistentTasksCustomMetaData.Assignment("current-data-node-with-1-tasks", "")) | ||
| .updateTaskState("failed-task", new DataFrameTransformState(DataFrameTransformTaskState.FAILED, | ||
| IndexerState.STOPPED, | ||
| null, | ||
| 0L, | ||
| "task has failed", | ||
| null)); | ||
| csBuilder = ClusterState.builder(new ClusterName("_name")).metaData(buildMetadata(pTasksBuilder.build())); | ||
|
|
||
| TransportStopDataFrameTransformAction.validateTaskState(csBuilder.build(), Arrays.asList("non-failed-task", "failed-task"), true); | ||
|
|
||
| TransportStopDataFrameTransformAction.validateTaskState(csBuilder.build(), Collections.singletonList("non-failed-task"), false); | ||
|
|
||
| ClusterState.Builder csBuilderFinal = ClusterState.builder(new ClusterName("_name")).metaData(buildMetadata(pTasksBuilder.build())); | ||
| ElasticsearchStatusException ex = expectThrows(ElasticsearchStatusException.class, | ||
| () -> TransportStopDataFrameTransformAction.validateTaskState(csBuilderFinal.build(), | ||
| Collections.singletonList("failed-task"), | ||
| false)); | ||
|
|
||
| assertThat(ex.status(), equalTo(CONFLICT)); | ||
| assertThat(ex.getMessage(), | ||
| equalTo(DataFrameMessages.getMessage(DataFrameMessages.DATA_FRAME_CANNOT_STOP_FAILED_TRANSFORM, | ||
| "failed-task", | ||
| "task has failed"))); | ||
| } | ||
|
|
||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: "Set frequency high" - DYM low? The default is 60s, so 1s is lower?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
High frequency => low time between repeats
(Similar to high frequency => short wavelength)
But if it's confusing then maybe bypass this by changing the comment to something like
// Set frequency to 1s to make the test run as fast as possible.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is one of those pedantic things that annoy me; frequency is measured in Hz not seconds, this is an interval. However, most people will read this and understand that frequency represents the period here and is probably the least confusing naming option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A high frequency in Hz means a short distance between cycles.
A high frequency here means a short time between attempts.